ephphatha
c2cf2f8b59
Refactor OperateShrineSparkling to use Point
...
Also added documentation about what the function does.
5 years ago
ephphatha
61a2cf9ac8
Refactor OperateShrineOily to use Point
...
Also added documentation about what the function does.
5 years ago
ephphatha
bc386a4701
Refactor OperateShrineDivine to use Point
...
Also added documentation about what the function does.
5 years ago
ephphatha
73cf62179c
Refactor ObjSetMini to use Point
5 years ago
ephphatha
e668d215f2
Refactor objects_set_door_piece to use a Point param
5 years ago
ephphatha
cbe542c52e
Refactor Add*Door functions to use more descriptive parameters
5 years ago
ephphatha
a3d155f552
Remove unnecessary temporaries from Obj_Light
...
This function can use Point member functions to perform the logic that determines when to show lights.
5 years ago
ephphatha
6f40f0dd88
Refactor ObjSetMicro to take a Point parameter
5 years ago
ephphatha
af7adda161
Refactor GetLight/SetLight to take Points instead of x/y params
...
Doing both functions at once as they are called from the same places with the same arguments.
They also operate on char values internally but get treated as if they are ints, might be more appropriate to use int8_t/uint8_t?
5 years ago
Anders Jenbo
6cd9935ef6
Bump warning level on MSVC
5 years ago
Anders Jenbo
72e888c27c
Enable CMP0092
5 years ago
Anders Jenbo
7f5ea145e9
Fix MSVC C4477 warning
...
Also take translation in to account when printing XP info
5 years ago
Anders Jenbo
bc51e1616d
🎨 Apply clang-tidy
5 years ago
Anders Jenbo
20262e4569
🚚 Move local symbols in to anon namespace
5 years ago
Anders Jenbo
903d4bd2e1
Scope all for loops
...
This caused 7 of the loops to be rewriteen using range by clang-tidy
5 years ago
ephphatha
8dbbdcca0d
remove unnecessary cast from MakeLightTable
...
Also changed the c-style cast to static_cast with appropriate type for destination.
5 years ago
ephphatha
949cb713d3
Add explicit casts to conversions from double/float to int
5 years ago
Vladimir Olteanu
c57560674e
Use smart pointers for UI items
...
vector::push_back(new Foo(...)) leaks if resizing fails
5 years ago
Anders Jenbo
2ca6e37c46
Clean up sub folders using clang-tidy/Android Studio
5 years ago
Anders Jenbo
9ebdb6db69
General clean up
5 years ago
Anders Jenbo
467b74dc06
Rename object globals
5 years ago
Anders Jenbo
9ae908f947
Rename missile globals
5 years ago
Anders Jenbo
9b8bf92575
Rename quest globals
5 years ago
Anders Jenbo
96bf75b502
Rename player globals
5 years ago
Anders Jenbo
dce78dde62
Rename lighting globals
5 years ago
Anders Jenbo
6d492e8220
Rename UI globals
5 years ago
Anders Jenbo
c8870dbd1f
Rename item globals
5 years ago
Anders Jenbo
07ad083fda
Rename monster globals
5 years ago
obligaron
be53349c2d
Decouple missile movement from game logic ( #2322 )
5 years ago
Gleb Mazovetskiy
65906f8332
🎉 Hardware cursor: Enable safe parts by default
...
Enables safe parts of the hardware cursor by default:
1. Disabled for items due to the jumping glitch.
2. Limited to 128px size due to buggy large cursors on some systems.
5 years ago
Anders Jenbo
ceaad03905
Cache GitHub Action build folders
5 years ago
Vladimir Olteanu
d969672895
Check for negative random values in tear fountain logic
5 years ago
Anders Jenbo
56d3b5d710
clang-tidy/Android Stuidio cleanups 5
5 years ago
Vladimir Olteanu
04751418e0
Refactor tear fountain logic; remove GenerateRnd loop
5 years ago
ephphatha
ab58d3d1ee
Reorder AddBeserk damage range adjustment calculations
...
This avoids forcing floating point conversions, the operation can safely be expressed as integral operations given the range of GenerateRnd and the types chosen for MonsterStruct::m*Damage*
5 years ago
ephphatha
51d05a3523
Reorder monster damage calculations to avoid warnings
...
This was giving type conversion warnings for the forced int > double > int conversion. The int + int operation in the middle was also flagged as it gets upcast during the multiplication (despite the values always being well within the range of an int) so using long constants there to avoid it.
5 years ago
ephphatha
d3c36166df
Add explicit cast for LogicalToOutput
...
In practice this function is only called with int arguments, can probably change the specialisation to std::is_integral<T>
5 years ago
ephphatha
be23f6864b
Reorder int *= float operations that could be expressed using int fractions
...
This was triggering narrowing conversion warnings in msvc. I assume the compiler can optimise this into a float multiplication if it does turn out faster.
5 years ago
ephphatha
08ae390643
Add explicit casts for some implicit conversions
...
Some of these were triggering multiple warnings due to casts applied at times which forced potentially truncating operations.
5 years ago
ephphatha
3520dc4201
Update numeric literals to use appropriate suffix
...
Mainly things like .F for floats instead of doubles in float context.
5 years ago
obligaron
e1e92ad777
Fix PlaceUniques calculates wrong monster type
5 years ago
obligaron
32b980ccb7
Rename GetVileMissPos -> UpdateVileMissPos
5 years ago
obligaron
d974826a07
Rename GetMissileVel -> UpdateMissileVel
5 years ago
obligaron
16fd46c6a2
Rename GetMissilePos -> UpdateMissilePos
5 years ago
obligaron
4db49ce6f9
Fix MI_Rhino don't update dMonster correctly
5 years ago
Andrew James
c7e3bb4ae7
Introduce template form of skip to represent deprecated variables ( #2309 )
5 years ago
Anders Jenbo
bc0d1f7ac0
clang-tidy/Android Stuidio cleanups 3
5 years ago
Anders Jenbo
d877287636
🐛 Correct missile ring offset
...
See https://github.com/diasurgical/devilution/pull/2237
5 years ago
Anders Jenbo
6690af350e
Clean up missiles.cpp
5 years ago
Vladimir Olteanu
2d3ad5e3f0
Main menu: make title char *
5 years ago