You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: 5226d5546c

1.3

1.4

1.5

AJenbo-patch-1

FindSlotUnderCursor

LineClear

LineClear-test

M_RoundWalk

access

amiga-fix

codeql

cpp20-using-enum

dev-app-icon

development

dun-data2

dyn-players

dyn-players-param

dyn-players-param2

fabiensanglard

fix-spectral-hack

glebm-patch-1

hubui

install

inv

julealgon/Enhancements/DamageStruct

master

maxexp

mutiny

next

player-max

ps2

psp

render

substitution

surface-to-cel

test

v1.0

w98-profile

wii

xad

xbrz

yuripourre-enhance-description

0.1.0

0.2.0

0.3.0

0.3.1

0.4.0

0.5.0

1.0.0

1.0.1

1.0.2

1.0.3

1.1.0

1.2.0

1.2.1

1.3.0

1.4.0

1.4.1

1.5.0

1.5.1

1.5.2

1.5.3

1.5.4

1.5.5

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '5226d5546c'

${ noResults }

devilutionX/Source

History

Roman Penyaev 5226d5546c lighting: fix vision through diagonally adjacent tiles ... This commit fixes a very subtle case where players could see through diagonally adjacent tiles. The bug was introduced in the recent commit: 88d0cb749f ("lighting: fix long-standing issue with invisible objects (#7901)"). The following 2D grid illustrates the bug: ``` . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . # # # # # # # # . . . . . . . # # . . . . . . . # # . . . . . . . # # . . . x . . . # # . . . . . . . # # . . . . . . . # # . . . . . . . # # # # # # # # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . ``` Where 'x' represents the player, surrounded by walls with diagonally adjacent corners, and '.' represents visible tiles reached by vision rays cast from the player's position. The figure clearly shows that rays "leak" through corners. The fix is quite simple: stop traversing the ray if "light" can't pass through the adjacent tiles or if the ray hits a tile that doesn't allow "light" to pass through. Previously, the ray continued to be traversed even when the "light" couldn't pass through the adjacent tiles, which is incorrect and leads to the described issue. Here is the Python script which simulates the bug and the fix: https://gist.github.com/rouming/8a24789fd5d18c36c40e2b4925915d16 Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>		12 months ago
..
DiabloUI	Handle loaded MPQ files in a map instead of bespoke globals (#7887)	12 months ago
controls	More consistent gamepad context sensitivity	1 year ago
data	Extract `HeadlessMode` from `diablo.h`	1 year ago
discord	Move option change handlers out of `options.cpp`	1 year ago
dvlnet	`sgOptions` -> `GetOptions()`	1 year ago
engine	Handle loaded MPQ files in a map instead of bespoke globals (#7887)	12 months ago
items	Make ears usable	1 year ago
levels	Do not deactivate dlvl 15 pentagram	12 months ago
lua	Lua: Add an item usertype	1 year ago
mpq	Do not depend on FileExists() when opening save files for writing	1 year ago
panels	Character Panel - CTH	1 year ago
platform	`sgOptions` -> `GetOptions()`	1 year ago
qol	Stores - IsPlayerInStore() (#7843)	1 year ago
storm	`sgOptions` -> `GetOptions()`	1 year ago
utils	Better asset path lookup for Haiku (#7927)	12 months ago
.clang-format	Migrate item data to txtdata/	2 years ago
.clang-tidy	Simplify txtdata parsing with a helper class	2 years ago
CMakeLists.txt	Lua: Add an item usertype	1 year ago
appfat.cpp	More dependency untangling	1 year ago
appfat.h	More dependency untangling	1 year ago
automap.cpp	BUGFIX: Search Effect not working with Minimap (#7919)	12 months ago
automap.h	Extract Is{Any,None}Of out of engine.hpp	1 year ago
capture.cpp	More dependency untangling	1 year ago
capture.h	…
codec.cpp	Rename endian.hpp to endian_read.hpp	1 year ago
codec.h	Remove utils/stdcompat/cstddef.hpp	3 years ago
control.cpp	Fix warning about not handling enumeration value 'None'	1 year ago
control.h	Menu text revision (#3902)	1 year ago
cpp.hint	…
crawl.cpp	Optimize `DoCrawl`	2 years ago
crawl.hpp	Extract Crawl to a library	2 years ago
cursor.cpp	Extract current input mode into its own library	1 year ago
cursor.h	Split up `engine.{h,cpp}`	1 year ago
dead.cpp	Extract `HeadlessMode` from `diablo.h`	1 year ago
dead.h	Split up `engine.{h,cpp}`	1 year ago
debug.cpp	Add missiles to tile data debug command	1 year ago
debug.h	Add missiles to tile data debug command	1 year ago
diablo.cpp	More consistent gamepad context sensitivity	1 year ago
diablo.h	Move QuickMessages to its own library	1 year ago
diablo_msg.cpp	Split up `engine.{h,cpp}`	1 year ago
diablo_msg.hpp	Split up `engine.{h,cpp}`	1 year ago
doom.cpp	Split up `engine.{h,cpp}`	1 year ago
doom.h	Split up `engine.{h,cpp}`	1 year ago
effects.cpp	More dependency untangling	1 year ago
effects.h	Extract sound effects enum into its own file	1 year ago
effects_stubs.cpp	Remove missing SfxID	2 years ago
encrypt.cpp	Deduplicate some of the MPQ handling	3 years ago
encrypt.h	Deduplicate some of the MPQ handling	3 years ago
game_mode.cpp	Move option change handlers out of `options.cpp`	1 year ago
game_mode.hpp	Move option change handlers out of `options.cpp`	1 year ago
gamemenu.cpp	Remove unused function in gamemenu.cpp	1 year ago
gamemenu.h	Menu text revision (#3902)	1 year ago
gmenu.cpp	Options: Remove dependency on demomode	1 year ago
gmenu.h	Split up `engine.{h,cpp}`	1 year ago
headless_mode.cpp	Extract `HeadlessMode` from `diablo.h`	1 year ago
headless_mode.hpp	Extract `HeadlessMode` from `diablo.h`	1 year ago
help.cpp	More dependency untangling	1 year ago
help.h	Split up `engine.{h,cpp}`	1 year ago
hwcursor.cpp	`sgOptions` -> `GetOptions()`	1 year ago
hwcursor.hpp	`sgOptions` -> `GetOptions()`	1 year ago
init.cpp	Handle loaded MPQ files in a map instead of bespoke globals (#7887)	12 months ago
init.h	Handle loaded MPQ files in a map instead of bespoke globals (#7887)	12 months ago
interfac.cpp	[3DS] Fix async loading	1 year ago
interfac.h	Async load: Handle errors	1 year ago
inv.cpp	Draw Hotkeys on Belt (#7911)	12 months ago
inv.h	Extract logic from CheckInvCut/AutoPlaceItemInInventory (#7494)	1 year ago
inv_iterators.hpp	Support `const` inventory iterators	3 years ago
itemdat.cpp	Allow for item drop rates up to 255 (#7533)	1 year ago
itemdat.h	Allow for item drop rates up to 255 (#7533)	1 year ago
items.cpp	Fix items.cpp:SortVendor() buffer overflow (#7875)	1 year ago
items.h	Make RecreateItem() take whole dwBuff flag as argument (#7870)	1 year ago
lighting.cpp	lighting: fix vision through diagonally adjacent tiles	12 months ago
lighting.h	More dependency untangling	1 year ago
loadsave.cpp	Make RecreateItem() take whole dwBuff flag as argument (#7870)	1 year ago
loadsave.h	Async load: Handle errors	1 year ago
main.cpp	…
menu.cpp	Handle loaded MPQ files in a map instead of bespoke globals (#7887)	12 months ago
menu.h	Add missing <cstdint> includes	3 years ago
minitext.cpp	Split up `engine.{h,cpp}`	1 year ago
minitext.h	Split up `engine.{h,cpp}`	1 year ago
misdat.cpp	Extract `HeadlessMode` from `diablo.h`	1 year ago
misdat.h	Async load: Handle errors	1 year ago
missiles.cpp	Fix Rage (#7873)	12 months ago
missiles.h	Split up `engine.{h,cpp}`	1 year ago
monstdat.cpp	Clean up selection type	2 years ago
monstdat.h	Extract sound effects enum into its own file	1 year ago
monster.cpp	Check for MonsterMode::Death in isPossibleToHit()	1 year ago
monster.h	More dependency untangling	1 year ago
movie.cpp	Extract current input mode into its own library	1 year ago
movie.h	…
msg.cpp	Make RecreateItem() take whole dwBuff flag as argument (#7870)	1 year ago
msg.h	Don't send spell level in spell casting network message	1 year ago
multi.cpp	`sgOptions` -> `GetOptions()`	1 year ago
multi.h	Big-endian networking fixes	1 year ago
nthread.cpp	fix many typos (#7322)	2 years ago
nthread.h	Add missing <cstdint> includes	3 years ago
objdat.cpp	Clean up selection type	2 years ago
objdat.h	Clean up selection type	2 years ago
objects.cpp	Untangle pathfinding dependencies	1 year ago
objects.h	Split up `engine.{h,cpp}`	1 year ago
options.cpp	Dynamic mod detection	1 year ago
options.h	Dynamic mod detection	1 year ago
pack.cpp	Make RecreateItem() take whole dwBuff flag as argument (#7870)	1 year ago
pack.h	Make invalid items unusable (#7506)	1 year ago
pfile.cpp	More dependency untangling	1 year ago
pfile.h	Async load: Handle errors	1 year ago
player.cpp	Fix compiler warning in Player::RemoveInvItem()	1 year ago
player.h	Handle loaded MPQ files in a map instead of bespoke globals (#7887)	12 months ago
playerdat.cpp	Fix typo in playerdat (#7072)	2 years ago
playerdat.hpp	Split up `engine.{h,cpp}`	1 year ago
plrmsg.cpp	text renderer: colors layout fix + improved tests	1 year ago
plrmsg.h	Split up `engine.{h,cpp}`	1 year ago
portal.cpp	Fix a few -Wsign-compare warnings	2 years ago
portal.h	Msg: Change OnXYZ to get a Player reference instead of a player index	2 years ago
quests.cpp	`sgOptions` -> `GetOptions()`	1 year ago
quests.h	Split up `engine.{h,cpp}`	1 year ago
quick_messages.cpp	Move QuickMessages to its own library	1 year ago
quick_messages.hpp	Move QuickMessages to its own library	1 year ago
restrict.cpp	…
restrict.h	…
sha.cpp	…
sha.h	Remove utils/stdcompat/cstddef.hpp	3 years ago
sound_effect_enums.h	Extract sound effects enum into its own file	1 year ago
spelldat.cpp	Fix a few more warnings	2 years ago
spelldat.h	Extract sound effects enum into its own file	1 year ago
spells.cpp	Extract game mode out of init.cpp	1 year ago
spells.h	Change CastSpell to Player reference	2 years ago
stores.cpp	Stores - Unhardcode shop values	1 year ago
stores.h	Stores - Unhardcode shop values	1 year ago
sync.cpp	Extract Is{Any,None}Of out of engine.hpp	1 year ago
sync.h	Use uint8_t in msg/multi/sync and fix MSVC warnings (#6856)	2 years ago
textdat.cpp	fix many typos (#7322)	2 years ago
textdat.h	Extract sound effects enum into its own file	1 year ago
tmsg.cpp	Remove utils/stdcompat/cstddef.hpp	3 years ago
tmsg.h	Remove utils/stdcompat/cstddef.hpp	3 years ago
towners.cpp	Fix debug command for talking to towners	1 year ago
towners.h	Fix debug command for talking to towners	1 year ago
track.cpp	Stores - IsPlayerInStore() (#7843)	1 year ago
track.h	…
translation_dummy.cpp	Remove "Book of " from `translation_dummy.cpp`	2 years ago