fd4b1f4246
Clean up 6 small functions in player.cpp
...
SetPlayerHitPoints, SetPlrStr, SetPlrMag, SetPlrDex, SetPlrVit and
InitDungMsgs are now bin exact
8 years ago
53955c120c
ModifyPlrDex and ModifyPlrVit are now binary exact
8 years ago
f066410d44
Clean up ModifyPlrVit
8 years ago
8525142fa8
Clean up ModifyPlrDex
8 years ago
503e5c1440
Names from DX SDK ( #197 )
8 years ago
5b1aa609fc
Clean up InitMultiView
8 years ago
31637532c9
Redefine nSolidTable as BYTE
...
Cleans PosOkMissile, CheckNoSolid, SolidLoc and LineClear
8 years ago
0900211d4a
Clean up PM_DoWalk2 && PM_DoWalk3
8 years ago
e0fca69c63
Clean up PM_DoStand and PM_DoWalk
8 years ago
6f81657988
Cleaned up the first few branches a bit more [readability]
8 years ago
e9d8931567
Now binary exact!
8 years ago
4bd4a3f432
Clean up PM_DoRangeAttack
8 years ago
5b3baf7508
Clean up PM_DoSpell
8 years ago
f0dec0b96c
Clean up ShieldDur && ShieldDur
8 years ago
ad1e782fe9
Clean up InitPlayerGFX
8 years ago
26a1135757
Clean up AddPlrMonstExper
8 years ago
ad8f018e98
SetPlayerGPtrs is now binary exact!
8 years ago
2be0ef7a2c
Clean up player_init_cl2_hdrs()
8 years ago
56d57d61c5
Update player.cpp
8 years ago
3b90e56429
Update player.cpp
8 years ago
f5a4d0a2ec
Reordered assignments in `NewPlrAnim` to be closer to the beta. Still binary exact with the new compiler
8 years ago
d45a175064
Fixed `CreatePlayer` to now be binary exact!
8 years ago
4120348056
Switched all pre-increments to post-increments, added some spacing
8 years ago
e750efcfce
Clean up NextPlrLevel
8 years ago
2e383d6810
Minor clean ups for player.cpp
8 years ago
0b29cbb97b
Reverted `MAX_PLRS` to raw literal without unsigned annotation
8 years ago
565a4b8bce
Flipped back the leveltype check
...
:S
8 years ago
9e18f07d5b
Cleaned up the if branches further, removed `pAnims` var so that register and instruction generation comes very close
8 years ago
cd99c0b800
Clean up player.cpp SetPlrAnims
8 years ago
9770783f41
Cleaned up `CreatePlayer` to be only one instruction off!
...
The devilution code generates one additional `cdq` instruction, the rest is perfect...
8 years ago
4ae7211fa0
Cleaned up `CreatePlayer`.
...
This is now as close as it gets without switching to enum types/parameters everywhere, so the compiler can optimize all accesses/checks accordingly. This is especially noticeable in the way the code for the switch is generated (line 775). In the original binary you can see it does weird stuff if c is not one of the classes' enum value (probably due to optimization since the switch should be exhaustive).
I've tried switching the type of c to _ui_classes, also removing the UI_NUM_CLASSES value to see if that'd be enough to let it generate the optimized code, but nope, seems like we need to change it all at once. Currently, _pClass is a char, but an enum value would fit there as well, size-wise (alignment).
That's also why I'm guessing there had to be another enum for player classes, without the UI_NUM_CLASSES value...
8 years ago
71c4c71796
Clean up player NewPlrAnim and ClearPlrPVars
8 years ago
5ed2336e90
Fix types of animation data ( #176 )
8 years ago
5ff8756116
Fix junk ( #174 )
8 years ago
0a3503dd55
Fix operating objects from top (sarcophagus)
8 years ago
0603e3e042
Cleaned up InitMonsterGFX, InitMonster, MonstPlace
8 years ago
fa64b2148d
Add defines [W.I.P] ( #160 )
8 years ago
a08be06427
Fix decompilation in player pathing
...
Doesn't fix any bugs sadly, the code still generates the same :(
8 years ago
a336c38226
Fix random(idx,v) calls ( #157 )
8 years ago
0200a2abba
Refactored spells.cpp ( #147 )
...
Finished refactoring spells.cpp, modifying other files only as needed.
Some functions are 99% binary exact now, like PlacePlayer, for example.
Added notes/TODOs for places with remaining discrepancies.
8 years ago
f50dab25ba
Several fixes for storm/msgcmd ( #146 )
8 years ago
c8af0523ac
refactor leveltype to use macros ( #103 )
8 years ago
87ca6557c3
Changed _oBreak and _oSelFlag to char ( #95 )
...
* Changed _oBreak and _oSelFlag to char
8 years ago
49a6f4f9fc
Add include guards, prepare for XRef ( #28 )
...
Add definitions, other junk.
8 years ago
7ee880f968
Fixed typos
8 years ago
bb01c6f084
Remove the "fear factor" ( #21 )
...
Snakes, spiders, Demons, what scares you?
8 years ago
0dac197965
Update player.cpp
8 years ago
f5f76f8b8a
Fix build on Linux
8 years ago
b1ee40f6e7
Revert "Add preliminary support for compiling on Linux"
8 years ago
20fdbf8aa2
Fix compile errors on Linux
...
Source/../types.h:35:10: fatal error: DiabloUI/_diabloui.h: No such file or directory
#include "DiabloUI/_diabloui.h"
---
Source/../Source/init.h:43:109: error: fastcall and stdcall attributes are not compatible
LRESULT (__stdcall *__fastcall SetWindowProc(void *func))(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam);
---
Source/missiles.cpp:915:27: error: unable to find numeric literal operator ‘operator""i64’
*(_QWORD *)&Dirs[0][2] = 0i64;
---
Source/world.cpp:38:1: error: narrowing conversion of ‘3937053354’ from ‘unsigned int’ to ‘int’ inside { } [-Wnarrowing]
---
Source/lighting.cpp:429:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing]
---
Source/objects.cpp:5459:62: error: unable to find numeric literal operator ‘operator""i64’
while ( !(plr[v53]._pMemSpells[1] & ((unsigned __int64)(1i64 << v60) >> 32) | plr[v53]._pMemSpells[0] & (unsigned int)(1i64 << v60)) );
---
Source/control.cpp:488:9: error: unable to find numeric literal operator ‘operator""i64’
v26 = 1i64;
---
Source/objects.cpp:243:1: error: narrowing conversion of ‘255’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/gamemenu.cpp:22:1: error: narrowing conversion of ‘2147483648’ from ‘unsigned int’ to ‘int’ inside { } [-Wnarrowing]
---
Source/sound.cpp:41:88: error: narrowing conversion of ‘240’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/quests.cpp:46:1: error: narrowing conversion of ‘255’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/player.cpp:4666:8: error: unable to find numeric literal operator ‘operator""i64’
v14 = 0i64;
---
Source/init.cpp:546:109: error: fastcall and stdcall attributes are not compatible
LRESULT (__stdcall *__fastcall SetWindowProc(void *func))(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
---
Source/items.cpp:114:1: error: narrowing conversion of ‘(item_effect_type)255’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/items.cpp:307:1: error: narrowing conversion of ‘(unique_base_item)255’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/items.cpp:854:8: error: unable to find numeric literal operator ‘operator""i64’
v37 = 0i64;
---
Source/items.cpp:471:1: error: narrowing conversion of ‘(item_equip_type)255’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
8 years ago
Anders Jenbo
Dennis Duda
galaxyhaxz
Dennis Duda
Stephan Unverwerth
Adam Heinermann
galaxyhaxz
mewmew