7b63273336
monster: add BUGFIX comment to DirOK
...
The issue here is probably very unlikely to trigger anything in-game, as
the first 4 monster array elements are reserverd for golems. However,
after executing the body of the `if (mi != 0) { mi-- }` if-statement,
it is not possible to determine whether mi was 0 or 1 before executing
the body. This is relevant as the pack member check should only be
performed if mi was non-zero prior to executing the body of the
if-statement.
A fixed may look something as follows:
if (mi != 0) {
mi--;
// BUGFIX: should only run pack member check if mi was non-zero prior to executing the body of the above if-statemnet (fixed).
if (monster[mi].leaderflag == 1
&& monster[mi].leader == i
&& monster[mi]._mfutx == x
&& monster[mi]._mfuty == y) {
mcount++;
}
6 years ago
7cabbb43f6
monster: add BUGFIX to MAI_Golum
...
The dMonster array stores monster array index numbers + 1
(or the corresponding negative version -(index + 1)).
Prior to use, these must be decremented by 1.
6 years ago
dc6f9b6585
missiles: add BUGFIX comment for GetDirection16
6 years ago
31ac716c3d
99 lines of documentation ( #2058 )
6 years ago
9821ff72d1
Document variables in drlg files
6 years ago
c1b4d3d8b5
Copy documentation from sanctuary/notes
6 years ago
1ba96a6777
Add doxygen description to remaining engine files
6 years ago
6448f7901b
stores: add bugfix comment for DrawSLine
6 years ago
60eb5c946c
items: add BUGFIX comment for DrawULine
6 years ago
c2df2635db
engine: add BUGFIX comment for Cl2BlitOutlineSafe
...
When hovering over a monster at the bottom part of the screen, the
outline may be off-by-one, thus overwriting the top pixel of the panel.
6 years ago
36e319cb7f
Add bugfix to MonstStartKill
6 years ago
8c2fb7605e
Use defines for tile and screen related magic numbers
6 years ago
af7f3f0f27
Bugfix for CheckCursMove ( #2046 )
6 years ago
7e45f8bcc8
More cleanups
6 years ago
b0a8a38462
clean magic numbers
6 years ago
e6fa244fa7
items: add BUGFIX comment for SaveItemPower
6 years ago
fe82c0b1f1
Clean up GetItemPower
...
Thanks @tsunamistate for bringing attention to this
6 years ago
46224337d8
Fix bin diff
6 years ago
452d6d25cc
docs: add function documentation to automap.cpp
6 years ago
23dca91a95
docs: add function documentation to appfat.cpp
6 years ago
7873bd4356
minitext: fix variable names of minitext.cpp
...
The variable names were mixed up.
sgLastScroll -> qtextSpd
scrolltexty -> qtextDelay
qtextSpd -> sgLastScroll
6 years ago
10be0c66e0
Correct ObjTypeConv
6 years ago
8c3ec91232
Use enums in the ObjTypeConv map
6 years ago
3b8bcf98bf
Enable assertions
6 years ago
e7567859ee
Remove C fallback code
6 years ago
350646fe95
Correct signatures
6 years ago
d008af43b0
Semantic code style cleanups
6 years ago
af7db10bac
Correct switch order for TraceErrorDD
...
This fixes the jump table at the end of the function
https://github.com/galaxyhaxz/devastation/blob/master/FIXES/appfat.cpp
6 years ago
f4c181dd70
Correct size of app_fatal
...
The call to ExitProcess(1) can be seen in the original ASM, but still
isen't emitted by the compiler for our code :/
6 years ago
295dc35429
Renable delete operator
...
This aligns the first instructions, now that we only target C++ it's we
can safly enable it. Should be moved to storm.h.
6 years ago
346c0949e7
Correct seed tables
6 years ago
9e2cefa522
Fix InitHash
6 years ago
2ec7c78eae
Format source
6 years ago
cee695c890
Clean up menu structures
6 years ago
edcd92e012
Misc clean ups that missed last round
6 years ago
cc280eeba3
Enable asserts in files that where cleaned
6 years ago
c9db23de5b
Correct sfx_* names, can be seen in assert strings
6 years ago
3ac90dc03f
Use NewCursor to set cursor
6 years ago
a94c2d656f
Make hashtable in to a 2d array
6 years ago
cd18914026
Avoid void pointers
6 years ago
be1a3f1503
Clean up gamemenu_on
6 years ago
6c6ae344de
Deduplicate strings in argument parsing
6 years ago
c3cdc1c4ab
Decompose magic numbers
6 years ago
6704657e71
Apply sematic codestyle
6 years ago
1340192b59
Correct array sizes
6 years ago
c09c37ec21
Create define for monsterAvailTbl
6 years ago
7db4ed749a
Apply more enums, defines and types
6 years ago
c384711a5f
Backport cleanups from hellfire branch
6 years ago
f1c216e688
Make player struct x/y fields match monster struct
6 years ago
054458845a
Fix CLang builds
...
Possibly the type of ObjDataStruct should be changed to byte
6 years ago
Robin Eklind
Anders Jenbo
qndel