We could add this back in future branches/releases but Mastodon has
changed how they handle external links broadly, so we would need a
different approach (particularly around the "pill" UI element they do
for remote domains in accounts)
The issue is in the dropdown_selector component, which stores data as a
`data-index` element on a dropdown. This means all values are cast to
strings in anything using that dropdown, which means we need to
unstringify on the `handleChange` function that (up in the component)
calls the `getAttribue` function. Anyway this means we can remove
terrible hacks in multiple places.
Work to maintain
- Permalinks (aka links outside the app instead of inside)
- Alt badges and no-alt badges and media-description-missing class for
audio/video
- Federation dropdowns and icons (local-only UI)
Main bits here are:
- retaining the "no alt text badge" and the custom class "media-missing-description" which lets admins apply custom CSS to media that doesn't have alt text
- agreeing with the upstream merge removing "noreferrer" from the
thumbnail link because that is now set by the admin in the UI: 425311e1d9
There was a major issue where remote posts weren't being signed
correctly. Or rather, the signing process wanted access to a constant
that was defined in the wrong file. This is probably due to a
backporting error since this is precisely the files that were part of
the big security patches.
There's a button that is supposed to render when an ActivityPub article
is received and the status is collapsed for being too long. Instead of
saying "read more" it says "read article" and takes you to the rendered
Article.
Linter was complaining about a missing "href" on Permalink in the
hashtag component, but when I dug in, it's a partially merged feature
from this PR:
https://github.com/hometown-fork/hometown/issues/1249
If you look at the PR, there was never meant to be hashtag-specific
permalink functionality (this was code applied from an external patch), and
regardless I just checked and the hashtag functionality never worked
anyway (opening hashtag links in new windows).
Displaying a remote profile would cause the app to crash due to unmerged
changes related to reverting in-app redirects back to normal, external
URL permalinks:
https://github.com/hometown-fork/hometown/pull/1249
Most of the references were fontAwesome SVG icons that we'd hacked
directly in to the CSS for some reason I forget. No longer needed.
`.notification__message .fa` just becomes `.notification-group__icon
.icon`; it's for changing the color of the little "the following message in
your notification is a Follow notification" icon to be an on-theme color.
Changed the target so it still works.
Got rid of some styling for a haml template that doesn't exist anymore.
Notably I'm leaving in some `.fa` references because they are still in
Mastodon! Probably a bug I'll file with them.
https://github.com/mastodon/mastodon/blob/v4.5.1/app/javascript/styles/mastodon/widgets.scss#L50-L65
There was some leftover code from an old Mastodon UI thing where there
was a modal rendering when choosing the federation options in Compose.
This change makes it consistent with the PrivacyDropdown component.
Fixes an issue where it was trying to render FontAwesome-style icons
still. I just copied what some of the other similar dropdowns do. This
also fixes a rendering error when displaying a local-only post, thought
the layout still needs fixing.
Darius Kazemi
Misty De Meo
rainbow-bamboo
