The intent for exporting the SHELL variable is to ensure that all
Makefile target comands are run with the amended PATH value that is
set via the "export PATH := ..." directive.
However, exporting PATH value is all that is necessary to ensure that
all target commands run with the amended PATH. It is not necessary to
*also* export a SHELL command that explicitly sets the PATH value.
Specifically: setting SHELL to use "env" to set the PATH environment
variable gets difficult if the PATH includes whitespace. make's
assignment right hand side parsing does not treat quotes as delimiters
of tokens. For example, the following directive in a Makefile results
in the FOO variable having 3 tokens, not 2:
FOO := bar "baz yow"
Therefore, achieving the overall goal of amending the PATH for all
Makefile target commands -- even if the PATH includes whitespace -- is
best achieved simply by not exporting the SHELL.
Signed-off-by: Ethan Dieterich <ethandieterich@gmail.com>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
I can build this via:
docker build --build-arg BASEIMAGE=gcr.io/distroless/static:latest -t andrew:distroless .
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
* Discard package "version"
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
* Inject api version
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
* Pass version arg to the dex API
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Unify the interface for reading web statics. Now it could read an
OS directory or get the content on live
One could use
//go:embed static
var webFiles embed.FS
anywhere and config dex server to take the file system by setting
WebConfig{WebFS: webFiles}
Signed-off-by: Rui Yang <ruiya@vmware.com>
Co-authored-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Go 1.9 removed "./..." matching the vendor directory while Go 1.10 added
build and test caching. This means we no longer need to grep out
vendored matches (except for golint which doesn't implement the same
behavior), and we no longer need to pre-build packages with "go build -i".
https://golang.org/doc/go1.9#vendor-dotdotdothttps://golang.org/doc/go1.10#build