Browse Source

server: all authorizations fail for disabled users

pull/138/head
Joe Bowers 11 years ago
parent
commit
fbbb3cc2df
  1. 2
      integration/user_api_test.go
  2. 4
      server/user.go
  3. 2
      user/api/api.go

2
integration/user_api_test.go

@ -182,7 +182,7 @@ func TestGetUser(t *testing.T) {
id: "ID-1",
token: userBadTokenDisabled,
errCode: http.StatusUnauthorized, // TODO test with custom err before merge
errCode: http.StatusUnauthorized,
}, {
id: "ID-1",

4
server/user.go

@ -200,10 +200,6 @@ func (s *UserMgmtServer) getCreds(r *http.Request) (api.Creds, error) {
return api.Creds{}, err
}
if usr.Disabled {
return api.Creds{}, api.ErrorUnauthorized
}
isAdmin, err := s.cir.IsDexAdmin(clientID)
if err != nil {
log.Errorf("userMgmtServer: GetCreds err: %q", err)

2
user/api/api.go

@ -197,7 +197,7 @@ func (u *UsersAPI) ListUsers(creds Creds, maxResults int, nextPageToken string)
}
func (u *UsersAPI) Authorize(creds Creds) bool {
return creds.User.Admin
return creds.User.Admin && !creds.User.Disabled
}
func userToSchemaUser(usr user.User) schema.User {

Loading…
Cancel
Save