Browse Source

test: update HandleCallback after merging OIDC PKCE (#4572)

Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
pull/4573/head
Maksim Nabokikh 3 weeks ago committed by GitHub
parent
commit
cf17fc68c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 4
      connector/gitlab/gitlab_test.go
  2. 2
      connector/microsoft/microsoft_test.go

4
connector/gitlab/gitlab_test.go

@ -127,7 +127,7 @@ func TestHandleCallbackCustomRootCADataEnablesTLSRequests(t *testing.T) {
req, err := http.NewRequest("GET", hostURL.String()+"?code=testcode", nil)
expectNil(t, err)
identity, err := conn.(connector.CallbackConnector).HandleCallback(connector.Scopes{Groups: false}, req)
identity, err := conn.(connector.CallbackConnector).HandleCallback(connector.Scopes{Groups: false}, nil, req)
if err != nil {
t.Fatalf("HandleCallback() error: %v", err)
}
@ -170,7 +170,7 @@ func TestHandleCallbackWithoutRootCADataFailsTLS(t *testing.T) {
req, err := http.NewRequest("GET", hostURL.String()+"?code=testcode", nil)
expectNil(t, err)
_, err = conn.(connector.CallbackConnector).HandleCallback(connector.Scopes{Groups: false}, req)
_, err = conn.(connector.CallbackConnector).HandleCallback(connector.Scopes{Groups: false}, nil, req)
if err == nil {
t.Fatalf("expected TLS error, got nil")
}

2
connector/microsoft/microsoft_test.go

@ -142,7 +142,7 @@ func TestUserNotInRequiredGroupFromGraphAPI(t *testing.T) {
tenant: tenant,
groups: []string{"a"},
}
_, err := c.HandleCallback(connector.Scopes{Groups: true}, req)
_, err := c.HandleCallback(connector.Scopes{Groups: true}, nil, req)
if err == nil {
t.Fatal("expected error when user is not in any required group, got nil")
}

Loading…
Cancel
Save