Browse Source

fix: Do not evaluate skipApproval on approval page (#3086)

Signed-off-by: MM53 <28218664+MM53@users.noreply.github.com>
pull/3352/head
MM53 2 years ago committed by GitHub
parent
commit
a0cf8b2dc2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 6
      server/handlers.go

6
server/handlers.go

@ -628,12 +628,6 @@ func (s *Server) handleApproval(w http.ResponseWriter, r *http.Request) {
switch r.Method {
case http.MethodGet:
// TODO: `finalizeLogin()` now sends code directly to client without going through this endpoint,
// the `if skipApproval { ... }` block needs to be removed after a grace period.
if s.skipApproval {
s.sendCodeResponse(w, r, authReq)
return
}
client, err := s.storage.GetClient(authReq.ClientID)
if err != nil {
s.logger.Errorf("Failed to get client %q: %v", authReq.ClientID, err)

Loading…
Cancel
Save