Browse Source

Full list of groups should include group names as well as group_name:team_name

pull/1340/head
Alexander Matyushentsev 7 years ago
parent
commit
20bc6cd353
  1. 5
      connector/github/github.go
  2. 3
      connector/github/github_test.go

5
connector/github/github.go

@ -391,9 +391,8 @@ func (c *githubConnector) userGroups(ctx context.Context, client *http.Client) (
groups := make([]string, 0)
for _, o := range orgs {
if teams, ok := orgTeams[o]; !ok {
groups = append(groups, o)
} else {
groups = append(groups, o)
if teams, ok := orgTeams[o]; ok {
for _, t := range teams {
groups = append(groups, formatTeamName(o, t))
}

3
connector/github/github_test.go

@ -53,9 +53,11 @@ func TestUserGroups(t *testing.T) {
expectNil(t, err)
expectEquals(t, groups, []string{
"org-1",
"org-1:team-1",
"org-1:team-2",
"org-1:team-3",
"org-2",
"org-2:team-4",
"org-3",
})
@ -95,6 +97,7 @@ func TestUserGroupsWithTeamNameFieldConfig(t *testing.T) {
expectNil(t, err)
expectEquals(t, groups, []string{
"org-1",
"org-1:team-1",
})
}

Loading…
Cancel
Save