You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: ef498f2baf

1.3

1.4

1.5

AJenbo-patch-1

FindSlotUnderCursor

LineClear

LineClear-test

M_RoundWalk

access

amiga-fix

codeql

cpp20-using-enum

dev-app-icon

development

dun-data2

dyn-players

dyn-players-param

dyn-players-param2

fabiensanglard

fix-spectral-hack

glebm-patch-1

hubui

install

inv

julealgon/Enhancements/DamageStruct

master

maxexp

mpqfs

mutiny

next

player-max

ps2

psp

render

substitution

surface-to-cel

test

v1.0

w98-profile

wii

xad

xbrz

yuripourre-enhance-description

0.1.0

0.2.0

0.3.0

0.3.1

0.4.0

0.5.0

1.0.0

1.0.1

1.0.2

1.0.3

1.1.0

1.2.0

1.2.1

1.3.0

1.4.0

1.4.1

1.5.0

1.5.1

1.5.2

1.5.3

1.5.4

1.5.5

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'ef498f2baf'

${ noResults }

devilutionX/Source

History

Gleb Mazovetskiy ef498f2baf Speed up `world_draw_black_tile` ... Previously, there were 2 loops to render all the lines of a diamond. This changes it to call `RenderLeftTriangle` + `RenderRightTriangle`. That's 4 loops + some extra clipping calculations Yet, this version is ~28% faster. I don't understand why it's faster at all. Perhaps it's only faster on some hardware? Modern computers are magic. Anyway, here are the (very surprising) results on my Ryzen 3950x: ``` BASELINE=master BENCHMARK=dun_render_benchmark git checkout "$BASELINE" tools/build_and_run_benchmark.py -B "build-reld-${BASELINE}" --no-run "$BENCHMARK" git checkout - tools/build_and_run_benchmark.py --no-run "$BENCHMARK" tools/linux_reduced_cpu_variance_run.sh ~/google-benchmark/tools/compare.py -a benchmarks \ "build-reld-${BASELINE}/${BENCHMARK}" "build-reld/${BENCHMARK}" \ --benchmark_filter='.*BlackTile.*' --benchmark_repetitions=10 ``` ``` Comparing build-reld-master/dun_render_benchmark to build-reld/dun_render_benchmark Benchmark Time CPU Time Old Time New CPU Old CPU New ------------------------------------------------------------------------------------------------------------------------ BM_RenderBlackTile_pvalue 0.0002 0.0002 U Test, Repetitions: 10 vs 10 BM_RenderBlackTile_mean -0.2786 -0.2786 156 113 156 113 BM_RenderBlackTile_median -0.2808 -0.2808 157 113 157 113 BM_RenderBlackTile_stddev -0.3148 -0.3138 1 1 1 1 BM_RenderBlackTile_cv -0.0503 -0.0488 0 0 0 0 OVERALL_GEOMEAN -0.2785 -0.2786 0 0 0 0 ```		2 years ago
..
DiabloUI	fix many typos (#7322)	2 years ago
controls	fix many typos (#7322)	2 years ago
data	Extract spell data to a TSV	2 years ago
discord	Add asserts to Displacement::magnitude()	2 years ago
dvlnet	Reduce map lookups in dvlnet	2 years ago
engine	Speed up `world_draw_black_tile`	2 years ago
levels	Add dun_render_benchmark	2 years ago
lua	change log type on missing optional lua assets from error to info	2 years ago
mpq	Add dun_render_benchmark	2 years ago
panels	Remove duplicate function definitions from control.h	2 years ago
platform	fix many typos (#7322)	2 years ago
qol	Migrate maps to unordered maps	2 years ago
storm	Fix remaining MSVC warnings in network code	2 years ago
utils	StaticVector: Add more container methods	2 years ago
.clang-format	Migrate item data to txtdata/	2 years ago
.clang-tidy	Simplify txtdata parsing with a helper class	2 years ago
CMakeLists.txt	Re-encode dungeon tiles to remove bloat	2 years ago
appfat.cpp	Remove utils/stdcompat/string_view.hpp	3 years ago
appfat.h	Remove utils/stdcompat/string_view.hpp	3 years ago
automap.cpp	Consolidate walk functions	2 years ago
automap.h	Automap: Add minimap display option (#6612)	3 years ago
capture.cpp	Take PNG screenshots by default in SDL2 builds	2 years ago
capture.h	Lowercase all file paths	4 years ago
codec.cpp	Remove utils/stdcompat/cstddef.hpp	3 years ago
codec.h	Remove utils/stdcompat/cstddef.hpp	3 years ago
control.cpp	Ensure that network timeout info shows up in the info panel	2 years ago
control.h	fix many typos (#7322)	2 years ago
cpp.hint	…
crawl.cpp	Optimize `DoCrawl`	2 years ago
crawl.hpp	Extract Crawl to a library	2 years ago
cursor.cpp	fix many typos (#7322)	2 years ago
cursor.h	Use a pointer to a player instance instead of network id for cursor hovering	2 years ago
dead.cpp	Add more missing <cstdint> includes	3 years ago
dead.h	Remove unique monster's light when no corpse is left behind	3 years ago
debug.cpp	Switch to ankerl::unordered_dense	2 years ago
debug.h	Switch to ankerl::unordered_dense	2 years ago
diablo.cpp	Add dun_render_benchmark	2 years ago
diablo.h	fix many typos (#7322)	2 years ago
diablo_msg.cpp	`text_render`: Replace optional args with struct	2 years ago
diablo_msg.hpp	Rename error -> diablo_msg	2 years ago
doom.cpp	Remove utils/stdcompat/optional.hpp	3 years ago
doom.h	…
effects.cpp	Remove missing SfxID	2 years ago
effects.h	Migrate misdat.cpp data to TSV	2 years ago
effects_stubs.cpp	Remove missing SfxID	2 years ago
encrypt.cpp	Deduplicate some of the MPQ handling	3 years ago
encrypt.h	Deduplicate some of the MPQ handling	3 years ago
engine.cpp	Remove byte order logic from half-transparency lookups	2 years ago
engine.h	fix many typos (#7322)	2 years ago
gamemenu.cpp	Convert _sfx_id in to class enum	2 years ago
gamemenu.h	Automap: Don't close automap when pressing spacebar with other windows open (#6713)	2 years ago
gmenu.cpp	Remove `LightTableIndex` global	2 years ago
gmenu.h	In-game menu: Fix slider click handling	4 years ago
help.cpp	`text_render`: Replace optional args with struct	2 years ago
help.h	…
hwcursor.cpp	Log an error if `SDL_CreateColorCursor` fails	3 years ago
hwcursor.hpp	Delay hardware cursor reinit until it is visible	3 years ago
init.cpp	Check DevilutionX version	2 years ago
init.h	Only check devilutionx.mpq version if it exists	2 years ago
interfac.cpp	Fix MSVC SDL1 warnings	2 years ago
interfac.h	Fix MSVC SDL1 warnings	2 years ago
inv.cpp	Optimize lit blending with light level 0	2 years ago
inv.h	fix many typos (#7322)	2 years ago
inv_iterators.hpp	Support `const` inventory iterators	3 years ago
itemdat.cpp	Conditionally set cursor graphic for unique items (#7067)	2 years ago
itemdat.h	Conditionally set cursor graphic for unique items (#7067)	2 years ago
items.cpp	fix many typos (#7322)	2 years ago
items.h	Randomize Unique Item Generation (Reverse compatible) (#7060)	2 years ago
lighting.cpp	Add dun_render_benchmark	2 years ago
lighting.h	Add dun_render_benchmark	2 years ago
loadsave.cpp	fix many typos (#7322)	2 years ago
loadsave.h	Add missing <cstdint> includes	3 years ago
main.cpp	Fix SDL MinGW build	4 years ago
menu.cpp	Remove SNetGet/SetLastError	2 years ago
menu.h	Add missing <cstdint> includes	3 years ago
minitext.cpp	Fix a few MSVC warnings	2 years ago
minitext.h	fix many typos (#7322)	2 years ago
misdat.cpp	Rename `MissileData` fields to match the TSV	2 years ago
misdat.h	Rename `MissileData` fields to match the TSV	2 years ago
missiles.cpp	Rename `MissileData` fields to match the TSV	2 years ago
missiles.h	fix many typos (#7322)	2 years ago
monstdat.cpp	Switch to ankerl::unordered_dense	2 years ago
monstdat.h	Migrate effect.cpp data to TSV	2 years ago
monster.cpp	fix many typos (#7322)	2 years ago
monster.h	Fix a few -Wsign-compare warnings	2 years ago
movie.cpp	Option to not pause the game when the window loses focus (#7046)	2 years ago
movie.h	…
msg.cpp	fix many typos (#7322)	2 years ago
msg.h	Sync monster spawn in multiplayer	2 years ago
multi.cpp	Capture the level seed and use it to skip failed dungeon layouts	2 years ago
multi.h	Use uint8_t in msg/multi/sync and fix MSVC warnings (#6856)	2 years ago
nthread.cpp	fix many typos (#7322)	2 years ago
nthread.h	Add missing <cstdint> includes	3 years ago
objdat.cpp	Migrate objdat.cpp data to TSV	2 years ago
objdat.h	Migrate objdat.cpp data to TSV	2 years ago
objects.cpp	fix many typos (#7322)	2 years ago
objects.h	Remove utils/stdcompat/abs.hpp	3 years ago
options.cpp	fix many typos (#7322)	2 years ago
options.h	Switch to ankerl::unordered_dense	2 years ago
pack.cpp	Randomize Unique Item Generation (Reverse compatible) (#7060)	2 years ago
pack.h	fix many typos (#7322)	2 years ago
pfile.cpp	fix many typos (#7322)	2 years ago
pfile.h	fix many typos (#7322)	2 years ago
player.cpp	Clean up StartRangeAttack() (#7207)	2 years ago
player.h	fix many typos (#7322)	2 years ago
playerdat.cpp	Fix typo in playerdat (#7072)	2 years ago
playerdat.hpp	Convert _sfx_id in to class enum	2 years ago
plrmsg.cpp	Fix some MSVC warnings	2 years ago
plrmsg.h	Simplify delay player messages	2 years ago
portal.cpp	Fix a few -Wsign-compare warnings	2 years ago
portal.h	Msg: Change OnXYZ to get a Player reference instead of a player index	2 years ago
quests.cpp	fix many typos (#7322)	2 years ago
quests.h	Replace ReturnLevel/LevelTyp/LvlPosition	3 years ago
restrict.cpp	Use SDL for creating file during RW test	4 years ago
restrict.h	…
sha.cpp	…
sha.h	Remove utils/stdcompat/cstddef.hpp	3 years ago
spelldat.cpp	Fix a few more warnings	2 years ago
spelldat.h	Migrate misdat.cpp data to TSV	2 years ago
spells.cpp	Change CastSpell to Player reference	2 years ago
spells.h	Change CastSpell to Player reference	2 years ago
stores.cpp	Clean up store inferface	2 years ago
stores.h	Remove utils/stdcompat/string_view.hpp	3 years ago
sync.cpp	Splitting CheckInvPaste() into smaller functions (#6984)	2 years ago
sync.h	Use uint8_t in msg/multi/sync and fix MSVC warnings (#6856)	2 years ago
textdat.cpp	fix many typos (#7322)	2 years ago
textdat.h	Convert _sfx_id in to class enum	2 years ago
tmsg.cpp	Remove utils/stdcompat/cstddef.hpp	3 years ago
tmsg.h	Remove utils/stdcompat/cstddef.hpp	3 years ago
towners.cpp	Fix a MSVC warning in towners.cpp	2 years ago
towners.h	Bugfix: Celia Infostring displaying after quest (#7009)	2 years ago
track.cpp	Change Player::getId() and MyPlayerId to uint8_t	2 years ago
track.h	…
translation_dummy.cpp	Remove "Book of " from `translation_dummy.cpp`	2 years ago