You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: 4ae7211fa0

1.3

1.4

1.5

AJenbo-patch-1

FindSlotUnderCursor

LineClear

LineClear-test

M_RoundWalk

access

amiga-fix

codeql

cpp20-using-enum

dependabot/github_actions/jidicula/clang-format-action-4.17.0

dev-app-icon

development

dun-data2

dyn-players

dyn-players-param

dyn-players-param2

fabiensanglard

fix-spectral-hack

glebm-patch-1

hubui

install

inv

julealgon/Enhancements/DamageStruct

master

maxexp

mpqfs

mutiny

next

player-max

ps2

psp

render

substitution

surface-to-cel

test

v1.0

w98-profile

wii

xad

xbrz

yuripourre-enhance-description

0.1.0

0.2.0

0.3.0

0.3.1

0.4.0

0.5.0

1.0.0

1.0.1

1.0.2

1.0.3

1.1.0

1.2.0

1.2.1

1.3.0

1.4.0

1.4.1

1.5.0

1.5.1

1.5.2

1.5.3

1.5.4

1.5.5

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '4ae7211fa0'

${ noResults }

devilutionX/Source

History

Dennis Duda 4ae7211fa0 Cleaned up `CreatePlayer`. ... This is now as close as it gets without switching to enum types/parameters everywhere, so the compiler can optimize all accesses/checks accordingly. This is especially noticeable in the way the code for the switch is generated (line 775). In the original binary you can see it does weird stuff if c is not one of the classes' enum value (probably due to optimization since the switch should be exhaustive). I've tried switching the type of c to _ui_classes, also removing the UI_NUM_CLASSES value to see if that'd be enough to let it generate the optimized code, but nope, seems like we need to change it all at once. Currently, _pClass is a char, but an enum value would fit there as well, size-wise (alignment). That's also why I'm guessing there had to be another enum for player classes, without the UI_NUM_CLASSES value...		8 years ago
..
appfat.cpp	Fix function signatures and others (#158)	8 years ago
appfat.h	Fix function signatures and others (#158)	8 years ago
automap.cpp	Fix function signatures and others (#158)	8 years ago
automap.h	Fix function signatures and others (#158)	8 years ago
capture.cpp	Fix junk (#174)	8 years ago
capture.h	Refactored capture.cpp. (#104)	8 years ago
codec.cpp	Add include guards, prepare for XRef (#28)	8 years ago
codec.h	Add include guards, prepare for XRef (#28)	8 years ago
control.cpp	refactor leveltype to use macros (#103)	8 years ago
control.h	Fix function signatures and others (#158)	8 years ago
cursor.cpp	Refactored spells.cpp (#147)	8 years ago
cursor.h	Add include guards, prepare for XRef (#28)	8 years ago
dead.cpp	Fix types of animation data (#176)	8 years ago
dead.h	Add defines [W.I.P] (#160)	8 years ago
debug.cpp	Add defines [W.I.P] (#160)	8 years ago
debug.h	Add defines [W.I.P] (#160)	8 years ago
diablo.cpp	Use WNDPROC type for window procedures (#162)	8 years ago
diablo.h	Use WNDPROC type for window procedures (#162)	8 years ago
doom.cpp	Add include guards, prepare for XRef (#28)	8 years ago
doom.h	Add include guards, prepare for XRef (#28)	8 years ago
drlg_l1.cpp	Fix dungeon generation of the Cathedral (#165)	8 years ago
drlg_l1.h	Add include guards, prepare for XRef (#28)	8 years ago
drlg_l2.cpp	Fix catacombs generation (#167)	8 years ago
drlg_l2.h	Update drlg_l2.h	8 years ago
drlg_l3.cpp	Fixed stuff after rebase	8 years ago
drlg_l3.h	Add include guards, prepare for XRef (#28)	8 years ago
drlg_l4.cpp	Fix tile transparency in "Hell" (#172)	8 years ago
drlg_l4.h	Add include guards, prepare for XRef (#28)	8 years ago
dthread.cpp	Fix signature of multi_send_pinfo(...) (#164)	8 years ago
dthread.h	Fix signature of multi_send_pinfo(...) (#164)	8 years ago
dx.cpp	Fix junk (#174)	8 years ago
dx.h	Fix junk (#174)	8 years ago
effects.cpp	Add defines [W.I.P] (#160)	8 years ago
effects.h	Add defines [W.I.P] (#160)	8 years ago
encrypt.cpp	Add include guards, prepare for XRef (#28)	8 years ago
encrypt.h	Add include guards, prepare for XRef (#28)	8 years ago
engine.cpp	Merge remote-tracking branch 'devilution/master'	8 years ago
engine.h	Merge remote-tracking branch 'devilution/master'	8 years ago
error.cpp	Add include guards, prepare for XRef (#28)	8 years ago
error.h	Add include guards, prepare for XRef (#28)	8 years ago
fault.cpp	Refactored fault.cpp (#101)	8 years ago
fault.h	Refactored fault.cpp (#101)	8 years ago
gamemenu.cpp	Fix junk (#174)	8 years ago
gamemenu.h	Fix junk (#174)	8 years ago
gendung.cpp	Cleaned up InitMonsterGFX, InitMonster, MonstPlace	8 years ago
gendung.h	Add defines [W.I.P] (#160)	8 years ago
gmenu.cpp	Add include guards, prepare for XRef (#28)	8 years ago
gmenu.h	Add include guards, prepare for XRef (#28)	8 years ago
help.cpp	Add include guards, prepare for XRef (#28)	8 years ago
help.h	Add include guards, prepare for XRef (#28)	8 years ago
init.cpp	Use WNDPROC type for window procedures (#162)	8 years ago
init.h	Use WNDPROC type for window procedures (#162)	8 years ago
interfac.cpp	Fix junk (#174)	8 years ago
interfac.h	Fix function signatures and others (#158)	8 years ago
inv.cpp	Fix random(idx,v) calls (#157)	8 years ago
inv.h	Add include guards, prepare for XRef (#28)	8 years ago
items.cpp	Some minor adjustments from more asm comparison work	8 years ago
items.h	Cleaned up `CalcPlrItemVals`	8 years ago
lighting.cpp	Add defines [W.I.P] (#160)	8 years ago
lighting.h	Add debug lighting, add cmd line note (#61)	8 years ago
loadsave.cpp	Add defines [W.I.P] (#160)	8 years ago
loadsave.h	Add include guards, prepare for XRef (#28)	8 years ago
logging.cpp	Refactored fault.cpp (#101)	8 years ago
logging.h	Refactored fault.cpp (#101)	8 years ago
mainmenu.cpp	Add include guards, prepare for XRef (#28)	8 years ago
mainmenu.h	Add include guards, prepare for XRef (#28)	8 years ago
minitext.cpp	Add include guards, prepare for XRef (#28)	8 years ago
minitext.h	Add include guards, prepare for XRef (#28)	8 years ago
missiles.cpp	Merge remote-tracking branch 'devilution/master'	8 years ago
missiles.h	Add defines [W.I.P] (#160)	8 years ago
monster.cpp	Merge remote-tracking branch 'devilution/master'	8 years ago
monster.h	Cleaned up `PlaceGroup`	8 years ago
movie.cpp	Fix junk (#174)	8 years ago
movie.h	Add include guards, prepare for XRef (#28)	8 years ago
mpqapi.cpp	Fix junk (#174)	8 years ago
mpqapi.h	Fix function signatures and others (#158)	8 years ago
msg.cpp	Fix portals/quests in multiplayer	8 years ago
msg.h	Fix sgJunk array (#177)	8 years ago
msgcmd.cpp	Fix junk (#174)	8 years ago
msgcmd.h	Add include guards, prepare for XRef (#28)	8 years ago
multi.cpp	Fix types of animation data (#176)	8 years ago
multi.h	Update multi.h	8 years ago
nthread.cpp	Add include guards, prepare for XRef (#28)	8 years ago
nthread.h	Add include guards, prepare for XRef (#28)	8 years ago
objects.cpp	Fix types of animation data (#176)	8 years ago
objects.h	Fix types of animation data (#176)	8 years ago
pack.cpp	Add defines [W.I.P] (#160)	8 years ago
pack.h	Add include guards, prepare for XRef (#28)	8 years ago
palette.cpp	Fix function signatures and others (#158)	8 years ago
palette.h	Fix function signatures and others (#158)	8 years ago
path.cpp	Refactored spells.cpp (#147)	8 years ago
path.h	Refactored spells.cpp (#147)	8 years ago
pfile.cpp	Add include guards, prepare for XRef (#28)	8 years ago
pfile.h	Add include guards, prepare for XRef (#28)	8 years ago
player.cpp	Cleaned up `CreatePlayer`.	8 years ago
player.h	Cleaned up `CreatePlayer`.	8 years ago
plrmsg.cpp	Add include guards, prepare for XRef (#28)	8 years ago
plrmsg.h	Add include guards, prepare for XRef (#28)	8 years ago
portal.cpp	Add defines [W.I.P] (#160)	8 years ago
portal.h	Add defines [W.I.P] (#160)	8 years ago
quests.cpp	Cleaned up `GetLevelMTypes`.	8 years ago
quests.h	Cleaned up `GetLevelMTypes`.	8 years ago
render.cpp	render.cpp -> add comments on cel type	8 years ago
render.h	Fix junk (#174)	8 years ago
restrict.cpp	Add include guards, prepare for XRef (#28)	8 years ago
restrict.h	Add include guards, prepare for XRef (#28)	8 years ago
scrollrt.cpp	Fix types of animation data (#176)	8 years ago
scrollrt.h	Fix types of animation data (#176)	8 years ago
setmaps.cpp	Add include guards, prepare for XRef (#28)	8 years ago
setmaps.h	Add include guards, prepare for XRef (#28)	8 years ago
sha.cpp	Add include guards, prepare for XRef (#28)	8 years ago
sha.h	Add include guards, prepare for XRef (#28)	8 years ago
sound.cpp	Fix function signatures and others (#158)	8 years ago
sound.h	Add include guards, prepare for XRef (#28)	8 years ago
spells.cpp	Refactored spells.cpp (#147)	8 years ago
spells.h	Refactored spells.cpp (#147)	8 years ago
stores.cpp	Fix function signatures and others (#158)	8 years ago
stores.h	Fix function signatures and others (#158)	8 years ago
sync.cpp	Add defines [W.I.P] (#160)	8 years ago
sync.h	Add defines [W.I.P] (#160)	8 years ago
textdat.cpp	Add include guards, prepare for XRef (#28)	8 years ago
textdat.h	Add include guards, prepare for XRef (#28)	8 years ago
themes.cpp	Add defines [W.I.P] (#160)	8 years ago
themes.h	Add defines [W.I.P] (#160)	8 years ago
tmsg.cpp	Add include guards, prepare for XRef (#28)	8 years ago
tmsg.h	Add include guards, prepare for XRef (#28)	8 years ago
town.cpp	Annotated and fixed World.cpp (#129)	8 years ago
town.h	Add include guards, prepare for XRef (#28)	8 years ago
towners.cpp	Fix types of animation data (#176)	8 years ago
towners.h	Fix types of animation data (#176)	8 years ago
track.cpp	Add include guards, prepare for XRef (#28)	8 years ago
track.h	Add include guards, prepare for XRef (#28)	8 years ago
trigs.cpp	Add defines [W.I.P] (#160)	8 years ago
trigs.h	Add defines [W.I.P] (#160)	8 years ago
wave.cpp	Add include guards, prepare for XRef (#28)	8 years ago
wave.h	Add include guards, prepare for XRef (#28)	8 years ago