Turns out the squashfs mount has some non-trivial RAM overhead.
Copy the game to local storage and run from there to avoid the overhead.
This completely eliminates long 0 FPS periods when running the demo for PGO.
It may be possible to reduce the overhead by setting
CONFIG_SQUASHFS_FRAGMENT_CACHE_SIZE kernel setting to 1.
1. Creates the missing `shared-dl` directory.
2. Unsets some environment variables that interfere with buildroot.
3. Disables `BR2_PER_PACKAGE_DIRECTORIES`, which prevented us
from using the partial sysroot build.
Also documents the `TOOLCHAIN=...` option in docs/building.md.
From GCC documentation:
> Perform interprocedural pointer analysis and interprocedural modification and reference analysis.
> This option can cause excessive memory and compile-time usage on large compilation units.
> It is not enabled by default at any optimization level.
Also forces the CMake generation to `make` because `ninja` gets into an
infinite loop for some reason on my laptop.
A PGO'd binary can be built as follows:
1. Build with `-DDEVILUTIONX_PROFILE_GENERATE=ON`.
3. Run the timedemo.
4. Build with `-DDEVILUTIONX_PROFILE_USE=ON`.
By default, the profile directory is at `${HOME}/devilutionx-profile`
Example for the RG99:
```bash
# Build the OPK for profiling data collection:
TOOLCHAIN=/opt/rs90-toolchain Packaging/OpenDingux/build.sh rg99 --profile-generate
# Copy the OPK to RG99:
scp -O build-rg99/devilutionx-rg99.opk rg99:/media/sdcard/apps
# Now, run the OPK. It will run the timedemo instead of the actual game and will take a couple of hours.
# ☕☕☕
# Copy the profiling data from RG99
scp -r -O rg99:/media/data/local/home/devilutionx-profile /tmp/devilutionx-profile
# Build the OPK use the collected profiling data:
TOOLCHAIN=/opt/rs90-toolchain Packaging/OpenDingux/build.sh rg99 --profile-use --profile-dir /tmp/devilutionx-profile
# Copy the resulting binary back to RG99
scp -O build-rg99/devilutionx-rg99.opk rg99:/media/sdcard/apps
```
`-O2` increases the binary size by 0.5 MiB which we can now afford.
Increasing buffer size to `768` improves performance (seems to be the
sweet spot).
15-20 FPS in dungeon on the max-mem OD fork.
1. Adds a `libdevilution_so` target when tests are enabled.
2. Each test file is now a separate binary target linked against `libdevilutionx_so` (can now run tests in parallel).
3. Tests are now defined in a separate `test/CMakeLists.txt` file.
4. Building the tests is now controlled by the standard `BUILD_TESTING` option (defined by CTest).
5. Tests are now built by default.
6. On CI, test errors are now reported.
Also:
* `.clang-format`: Enable SortIncludes in tests
* `path_test.cpp`: Fix -Wsign-compare
SDL_mixer can only stream a single music track
SDL_audiolib has unlimited streams.
With this change, we finally have streaming sounds (respecting
sfx_STREAM).
Audio options can now also be set via diablo.ini, which should help us
better diagnose the static noise issues.
Unfortunately, OD Beta has a major regression with SDL joystick support,
as it always reports buttons as keyboard keys instead of actual buttons.
This partially breaks external keyboard support, where e.g. space no
longer acts as expected.
However, on balance, OD Beta is better than the 2014 firmware at this
point.
1. Now that all the buildroots we need are open-source,
use defconfigs that ship with them instead of rolling our own.
2. New script: Packagaging/OpenDingux/build-all.sh
3. To avoid polluting top-level home directory, buildroot location
changed to `~/devilutionx-buildroot/$BUILDROOT_TARGET`.
4. Move OPK packaging script to its own file. This is to be able
to make a package for devilutionX in the buildroot itself.
Start and Select are swapped in this version because Start + D-Pad controls backlight on the GKD350h.
There is nothing to map mouse emulation to in this version because of this but it isn't necessary to play the game.
This version looks uglier than on RG350 because it uses software scaling beacuse the IPU on the GKD350h doesn't work.
1. Use RetroFW buildroot directly as it is now open-source.
2. Build in separate build directories.
This lets us build them in parallel and preserves cmake cache across build.
Previously, there was an issue with the RG350 buildroot that necessitated building the entire thing.
That issue has been fixed and we can now build only the minimal set of dependencies (same as we do for RetroFW).
* Refactor OpenDingux build scripts
Created a common build.sh script that takes the target architecture as a
command line argument.
Updated existing build scripts, now they call build.sh with the matching
target.
This avoids code duplication and should help maintaining the build
script.
* Split the buildroot prepare and build steps
If the buildroot compilation fails, it will be run again the next time
the script is called. This was not the case before, as the buildroot
step was skipped when the buildroot folder existed.
* minor fixes
Gleb Mazovetskiy
Anders Jenbo
Guillaume Roche