You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
246 lines
10 KiB
246 lines
10 KiB
{ |
|
"ignored_warnings": [ |
|
{ |
|
"warning_type": "SQL Injection", |
|
"warning_code": 0, |
|
"fingerprint": "19df3740b8d02a9fe0eb52c939b4b87d3a2a591162a6adfa8d64e9c26aeebe6d", |
|
"check_name": "SQL", |
|
"message": "Possible SQL injection", |
|
"file": "app/models/status.rb", |
|
"line": 106, |
|
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/", |
|
"code": "result.joins(\"INNER JOIN statuses_tags t#{id} ON t#{id}.status_id = statuses.id AND t#{id}.tag_id = #{id}\")", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Status", |
|
"method": null |
|
}, |
|
"user_input": "id", |
|
"confidence": "Weak", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "SQL Injection", |
|
"warning_code": 0, |
|
"fingerprint": "30dfe36e87fe1b8f239df9a33d576e44a9863f73b680198d4713be6540ae61d3", |
|
"check_name": "SQL", |
|
"message": "Possible SQL injection", |
|
"file": "app/models/trends/query.rb", |
|
"line": 76, |
|
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/", |
|
"code": "klass.joins(\"join unnest(array[#{ids.join(\",\")}]) with ordinality as x (id, ordering) on #{klass.table_name}.id = x.id\")", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Trends::Query", |
|
"method": "to_arel" |
|
}, |
|
"user_input": "ids.join(\",\")", |
|
"confidence": "Weak", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Redirect", |
|
"warning_code": 18, |
|
"fingerprint": "5fad11cd67f905fab9b1d5739d01384a1748ebe78c5af5ac31518201925265a7", |
|
"check_name": "Redirect", |
|
"message": "Possible unprotected redirect", |
|
"file": "app/controllers/remote_interaction_controller.rb", |
|
"line": 24, |
|
"link": "https://brakemanscanner.org/docs/warning_types/redirect/", |
|
"code": "redirect_to(RemoteFollow.new(resource_params).interact_address_for(Status.find(params[:id])))", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "RemoteInteractionController", |
|
"method": "create" |
|
}, |
|
"user_input": "RemoteFollow.new(resource_params).interact_address_for(Status.find(params[:id]))", |
|
"confidence": "High", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Cross-Site Scripting", |
|
"warning_code": 2, |
|
"fingerprint": "71cf98c8235b5cfa9946b5db8fdc1a2f3a862566abb34e4542be6f3acae78233", |
|
"check_name": "CrossSiteScripting", |
|
"message": "Unescaped model attribute", |
|
"file": "app/views/admin/disputes/appeals/_appeal.html.haml", |
|
"line": 7, |
|
"link": "https://brakemanscanner.org/docs/warning_types/cross_site_scripting", |
|
"code": "t((Unresolved Model).new.strike.action, :scope => \"admin.strikes.actions\", :name => content_tag(:span, (Unresolved Model).new.strike.account.username, :class => \"username\"), :target => content_tag(:span, (Unresolved Model).new.account.username, :class => \"target\"))", |
|
"render_path": [ |
|
{ |
|
"type": "template", |
|
"name": "admin/disputes/appeals/index", |
|
"line": 20, |
|
"file": "app/views/admin/disputes/appeals/index.html.haml", |
|
"rendered": { |
|
"name": "admin/disputes/appeals/_appeal", |
|
"file": "app/views/admin/disputes/appeals/_appeal.html.haml" |
|
} |
|
} |
|
], |
|
"location": { |
|
"type": "template", |
|
"template": "admin/disputes/appeals/_appeal" |
|
}, |
|
"user_input": "(Unresolved Model).new.strike", |
|
"confidence": "Weak", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "SQL Injection", |
|
"warning_code": 0, |
|
"fingerprint": "75fcd147b7611763ab6915faf8c5b0709e612b460f27c05c72d8b9bd0a6a77f8", |
|
"check_name": "SQL", |
|
"message": "Possible SQL injection", |
|
"file": "lib/mastodon/snowflake.rb", |
|
"line": 87, |
|
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/", |
|
"code": "connection.execute(\"CREATE OR REPLACE FUNCTION timestamp_id(table_name text)\\nRETURNS bigint AS\\n$$\\n DECLARE\\n time_part bigint;\\n sequence_base bigint;\\n tail bigint;\\n BEGIN\\n time_part := (\\n -- Get the time in milliseconds\\n ((date_part('epoch', now()) * 1000))::bigint\\n -- And shift it over two bytes\\n << 16);\\n\\n sequence_base := (\\n 'x' ||\\n -- Take the first two bytes (four hex characters)\\n substr(\\n -- Of the MD5 hash of the data we documented\\n md5(table_name || '#{SecureRandom.hex(16)}' || time_part::text),\\n 1, 4\\n )\\n -- And turn it into a bigint\\n )::bit(16)::bigint;\\n\\n -- Finally, add our sequence number to our base, and chop\\n -- it to the last two bytes\\n tail := (\\n (sequence_base + nextval(table_name || '_id_seq'))\\n & 65535);\\n\\n -- Return the time part and the sequence part. OR appears\\n -- faster here than addition, but they're equivalent:\\n -- time_part has no trailing two bytes, and tail is only\\n -- the last two bytes.\\n RETURN time_part | tail;\\n END\\n$$ LANGUAGE plpgsql VOLATILE;\\n\")", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Mastodon::Snowflake", |
|
"method": "define_timestamp_id" |
|
}, |
|
"user_input": "SecureRandom.hex(16)", |
|
"confidence": "Medium", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Mass Assignment", |
|
"warning_code": 105, |
|
"fingerprint": "7631e93d0099506e7c3e5c91ba8d88523b00a41a0834ae30031a5a4e8bb3020a", |
|
"check_name": "PermitAttributes", |
|
"message": "Potentially dangerous key allowed for mass assignment", |
|
"file": "app/controllers/api/v2/search_controller.rb", |
|
"line": 28, |
|
"link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/", |
|
"code": "params.permit(:type, :offset, :min_id, :max_id, :account_id)", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Api::V2::SearchController", |
|
"method": "search_params" |
|
}, |
|
"user_input": ":account_id", |
|
"confidence": "High", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Mass Assignment", |
|
"warning_code": 105, |
|
"fingerprint": "874be88fedf4c680926845e9a588d3197765a6ccbfdd76466b44cc00151c612e", |
|
"check_name": "PermitAttributes", |
|
"message": "Potentially dangerous key allowed for mass assignment", |
|
"file": "app/controllers/api/v1/admin/reports_controller.rb", |
|
"line": 90, |
|
"link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/", |
|
"code": "params.permit(:resolved, :account_id, :target_account_id)", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Api::V1::Admin::ReportsController", |
|
"method": "filter_params" |
|
}, |
|
"user_input": ":account_id", |
|
"confidence": "High", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Mass Assignment", |
|
"warning_code": 105, |
|
"fingerprint": "ab5035dd1a9f8c3a8d92fb2c37e8fe86fede4f87c91b71aa32e89c9eede602fc", |
|
"check_name": "PermitAttributes", |
|
"message": "Potentially dangerous key allowed for mass assignment", |
|
"file": "app/controllers/api/v1/notifications_controller.rb", |
|
"line": 81, |
|
"link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/", |
|
"code": "params.permit(:account_id, :types => ([]), :exclude_types => ([]))", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Api::V1::NotificationsController", |
|
"method": "browserable_params" |
|
}, |
|
"user_input": ":account_id", |
|
"confidence": "High", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Redirect", |
|
"warning_code": 18, |
|
"fingerprint": "ba568ac09683f98740f663f3d850c31785900215992e8c090497d359a2563d50", |
|
"check_name": "Redirect", |
|
"message": "Possible unprotected redirect", |
|
"file": "app/controllers/remote_follow_controller.rb", |
|
"line": 21, |
|
"link": "https://brakemanscanner.org/docs/warning_types/redirect/", |
|
"code": "redirect_to(RemoteFollow.new(resource_params).subscribe_address_for(@account))", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "RemoteFollowController", |
|
"method": "create" |
|
}, |
|
"user_input": "RemoteFollow.new(resource_params).subscribe_address_for(@account)", |
|
"confidence": "High", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Cross-Site Scripting", |
|
"warning_code": 4, |
|
"fingerprint": "cd5cfd7f40037fbfa753e494d7129df16e358bfc43ef0da3febafbf4ee1ed3ac", |
|
"check_name": "LinkToHref", |
|
"message": "Potentially unsafe model attribute in `link_to` href", |
|
"file": "app/views/admin/trends/links/_preview_card.html.haml", |
|
"line": 7, |
|
"link": "https://brakemanscanner.org/docs/warning_types/link_to_href", |
|
"code": "link_to((Unresolved Model).new.title, (Unresolved Model).new.url)", |
|
"render_path": [ |
|
{ |
|
"type": "template", |
|
"name": "admin/trends/links/index", |
|
"line": 49, |
|
"file": "app/views/admin/trends/links/index.html.haml", |
|
"rendered": { |
|
"name": "admin/trends/links/_preview_card", |
|
"file": "app/views/admin/trends/links/_preview_card.html.haml" |
|
} |
|
} |
|
], |
|
"location": { |
|
"type": "template", |
|
"template": "admin/trends/links/_preview_card" |
|
}, |
|
"user_input": "(Unresolved Model).new.url", |
|
"confidence": "Weak", |
|
"note": "" |
|
}, |
|
{ |
|
"warning_type": "Mass Assignment", |
|
"warning_code": 105, |
|
"fingerprint": "f9de0ca4b04ae4b51b74d98db14dcbb6dae6809e627b58e711019cf9b4a47866", |
|
"check_name": "PermitAttributes", |
|
"message": "Potentially dangerous key allowed for mass assignment", |
|
"file": "app/controllers/api/v1/reports_controller.rb", |
|
"line": 26, |
|
"link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/", |
|
"code": "params.permit(:account_id, :comment, :category, :forward, :status_ids => ([]), :rule_ids => ([]))", |
|
"render_path": null, |
|
"location": { |
|
"type": "method", |
|
"class": "Api::V1::ReportsController", |
|
"method": "report_params" |
|
}, |
|
"user_input": ":account_id", |
|
"confidence": "High", |
|
"note": "" |
|
} |
|
], |
|
"updated": "2022-03-22 07:48:32 +0100", |
|
"brakeman_version": "5.2.1" |
|
}
|
|
|