hometown

11144 Commits

16 Branches

215 Tags

374 MiB

Tree: aed98fd4dd

Commit Graph

Author	SHA1	Message	Date
Claire	e38fc319dc	Refactor and improve tests (#17386 ) * Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.	4 years ago
Yamagishi Kazutoshi	d10447c3a8	Use raw status code on have_http_status (#7214 )	8 years ago
Emelia Smith	219a4423d8	Feature: Allow staff to change user emails (#7074 ) * Admin: Show unconfirmed email address on account page * Admin: Allow staff to change user email addresses * ActionLog: On change_email, log current email address and new unconfirmed email address	8 years ago

Author

SHA1

Message

Date

Claire

e38fc319dc

Refactor and improve tests (#17386 )

* Change account and user fabricators to simplify and improve tests

- `Fabricate(:account)` implicitly fabricates an associated `user` if
  no `domain` attribute is given (an account with `domain: nil` is
  considered a local account, but no user record was created), unless
  `user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
  but is discouraged.

* Fix and refactor tests

- avoid passing unneeded attributes to `Fabricate(:user)` or
  `Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
  way around
- prefer `Fabricate(:user, account_attributes: …)` to
  `Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
  not representative of production code.

4 years ago

Yamagishi Kazutoshi

d10447c3a8

Use raw status code on have_http_status (#7214 )

8 years ago

Emelia Smith

219a4423d8

Feature: Allow staff to change user emails (#7074 )

* Admin: Show unconfirmed email address on account page

* Admin: Allow staff to change user email addresses

* ActionLog: On change_email, log current email address and new unconfirmed email address

8 years ago

3 Commits (aed98fd4ddc41b48522aeda609e0e30998f5e4e1)