hometown

11686 Commits

16 Branches

215 Tags

370 MiB

Tree: 7b5100aaed

Commit Graph

Author	SHA1	Message	Date
Sasha Sorokin	cb2adaaf9d	Replace shortNumberFormat with <ShortNumber> (#14061 ) This commit introduces new utility component - ShortNumber. It should work almost the same way as original shortNumberFormat function, though it also localizes units and accepts one more prop - renderer. Renderer is a function that takes rendered short formatted number and also ready-to-pluralize number to format display result accordingly. Ready-to-pluralize number allows to correctly select plural for compactly notated numbers, respecting thousands and other units. Issue #12451 accurately describes the issue with using raw numbers when replacing counter with short version. In short, it doesn't work with languages such as Russian, that require different plurals, according to the unit number was compacted to. All previous usages of shortNumberFormat were replaced with new function, and as it became unused, it was removed to avoid misleading.	6 years ago

Author

SHA1

Message

Date

Sasha Sorokin

cb2adaaf9d

Replace shortNumberFormat with <ShortNumber> (#14061 )

This commit introduces new utility component - ShortNumber. It should
work almost the same way as original shortNumberFormat function,
though it also localizes units and accepts one more prop - renderer.

Renderer is a function that takes rendered short formatted number
and also ready-to-pluralize number to format display result accordingly.
Ready-to-pluralize number allows to correctly select plural for
compactly notated numbers, respecting thousands and other units.

Issue #12451 accurately describes the issue with using raw numbers
when replacing counter with short version. In short, it doesn't work
with languages such as Russian, that require different plurals,
according to the unit number was compacted to.

All previous usages of shortNumberFormat were replaced with new
function, and as it became unused, it was removed to avoid misleading.

6 years ago

1 Commits (7b5100aaedc27fbc60cf4064313dcafe237bdf53)