hometown

10928 Commits

16 Branches

215 Tags

374 MiB

Tree: 53aca8aecf

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Akihiko Odaki	ae871c4d46	Make Array-creation behavior of Paginable more predictable (#14687 ) * Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: - `552e886b64` - `b63ede5005` - `64ef37b89d` To prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.	6 years ago
Eugen Rochko	7696f77245	Add moderation API (#9387 ) Fix #8580 Fix #7143	7 years ago

Akihiko Odaki

ae871c4d46

Make Array-creation behavior of Paginable more predictable (#14687 )

* Make Array-creation behavior of Paginable more predictable

Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it
returns an Array if min_id option is present. The behavior caused problems
fixed with the following commits:
- 552e886b64
- b63ede5005
- 64ef37b89d

To prevent from recurring similar problems, this commit introduces two
changes:
- The scope now always returns an Array whether min_id option is present
  or not.
- The scope is renamed to to_a_paginated_by_id to clarify it returns an
  Array.

* Transform Paginable.to_a_paginated_by_id from a scope to a class method

https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope
> The method is intended to return an ActiveRecord::Relation object, which
> is composable with other scopes.

Paginable.to_a_paginated_by_id returns an Array and is not appropriate
as a scope.

6 years ago

Eugen Rochko

7696f77245

Add moderation API (#9387 )

Fix #8580
Fix #7143

7 years ago

2 Commits (53aca8aecf33ca47825da8b2d10ecff089df5c64)