hometown

5362 Commits

16 Branches

215 Tags

373 MiB

Tree: 00ff8dc00a

Commit Graph

Author	SHA1	Message	Date
Eugen Rochko	92cb451da8	Fix #4026 - Accept backup codes for disabling 2FA (#4382 )	9 years ago
Eugen Rochko	5e8d037e27	Fix #3910 - Require OTP authentication to disable 2FA (#3935 ) * Fix #3910 - Require OTP authentication to disable 2FA. Also, remove ability to generate new OTP backup codes after initial backup codes were handed out during activation * Restore recovery code re-generation * Improve display of some 2FA elements	9 years ago
Matt Jankowski	67dea31b0f	2FA controller cleanup (#2296 ) * Add spec coverage for settings/two_factor_auth area * extract setup method for qr code * Move otp required check to before action * Merge method only used once * Remove duplicate view * Consolidate creation of @codes for backup * Move settings/2fq#recovery_codes to settings/recovery_codes#create * Rename settings/two_factor_auth#disable to #destroy * Add coverage for the otp required path on 2fa#show * Clean up the recovery codes list styles * Move settings/two_factor_auth to settings/two_factor_authentication * Reorganize the settings two factor auth area Updated to use a flow like: - settings/two_factor_authentication goes to a #show view which has a button either enable or disable 2fa on the account - the disable button turns off the otp requirement for the user - the enable button cycles the user secret and redirects to a confirmation page - the confirmation page is a #new view which shows the QR code for user - that page posts to #create which verifies the code, and creates the recovery codes - that create action shares a view with a recovery codes controller which can be used separately to reset codes if needed	9 years ago

Author

SHA1

Message

Date

Eugen Rochko

92cb451da8

Fix #4026 - Accept backup codes for disabling 2FA (#4382 )

9 years ago

Eugen Rochko

5e8d037e27

Fix #3910 - Require OTP authentication to disable 2FA (#3935 )

* Fix #3910 - Require OTP authentication to disable 2FA. Also, remove ability
to generate new OTP backup codes *after* initial backup codes were handed
out during activation

* Restore recovery code re-generation

* Improve display of some 2FA elements

9 years ago

Matt Jankowski

67dea31b0f

2FA controller cleanup (#2296 )

* Add spec coverage for settings/two_factor_auth area

* extract setup method for qr code

* Move otp required check to before action

* Merge method only used once

* Remove duplicate view

* Consolidate creation of @codes for backup

* Move settings/2fq#recovery_codes to settings/recovery_codes#create

* Rename settings/two_factor_auth#disable to #destroy

* Add coverage for the otp required path on 2fa#show

* Clean up the recovery codes list styles

* Move settings/two_factor_auth to settings/two_factor_authentication

* Reorganize the settings two factor auth area

Updated to use a flow like:

- settings/two_factor_authentication goes to a #show view which has a button
  either enable or disable 2fa on the account
- the disable button turns off the otp requirement for the user
- the enable button cycles the user secret and redirects to a confirmation page
- the confirmation page is a #new view which shows the QR code for user
- that page posts to #create which verifies the code, and creates the recovery
  codes
- that create action shares a view with a recovery codes controller which can be
  used separately to reset codes if needed

9 years ago

3 Commits (00ff8dc00a3b3bbf5334fe889c27cb8b6956ccca)