Unclosed connection leak when replacing pooled connection in SharedTimedStack.try_create (#37335)

2 months ago · 2c18917c81
1 changed files with 1 additions and 0 deletions
--- a/app/lib/connection_pool/shared_timed_stack.rb
+++ b/app/lib/connection_pool/shared_timed_stack.rb
@ -71,6 +71,7 @@ class ConnectionPool::SharedTimedStack
      throw_away_connection = @queue.pop
      @tagged_queue[throw_away_connection.site].delete(throw_away_connection)
      @create_block.call(preferred_tag)
+      throw_away_connection.close
    elsif @created != @max
      connection = @create_block.call(preferred_tag)
      @created += 1