You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

93 lines
2.9 KiB

Bringing Hometown up to date with mastodon/mastodon (#1371) This is a massive PR, so apologies for the poor performance viewing it! This merges in the content of Mastodon 4.3.0. *This PR isn't ready to deploy to production*, and I don't recommend trying it in a production environment. Since I started by merging 4.3.0, this will likely have reverted at least some of the content of the post-4.3.0 security patches in the 4.2.x series; those will be brought back as I merge in 4.4.0 and 4.5.0. I haven't yet tested this PR, so it may not actually run without additional tweaks. I'm putting it up now for discussion and so multiple people can test if we want. --- Here's a few notes on things I ran into and thoughts I had while working on it: * We may want to look at `server_banner.jsx,` where I ended up undoing the v3-style rewrite due to the new react component being used. I'm not sure what the current goal for it is. * I may not have 100% merged in all content from `status_action_bar` correctly. * There's a number of places where I updated the links for remote usernames, and they should be tested to make sure they work. They're all `<Permalink>` elements. I have in my notes that `status_content` might need double-checking. * I may also not have gotten the spoiler display right in `status_content`. * It looks like previous versions of Hometown had customizations to the `media_item` display, not all of which was preserved as-is due to surrounding rewrites. I'm not sure what the vision is and could use another set of eyes. * The character count rendering clashed with the newly-introduced handling of a character count variable upstream, and I'm not sure if the version I've got here 100% works or not. * The navigation bar was completely rewritten and no longer has the components Hometown was customizing; did I properly catch any replacements? Did we handle all links to accounts to make sure they go to the remote instance? * Polls: I reverted the single/multiple choice toggle because upstream has an actual proper UI for this that should be integrated in one of the versions we’re merging in. Please double-check that the current version looks fine to you. * The font icons will need double-checking. Hometown made some custom use of the font-awesome icons, while Mastodon 4.3.0 replaced font-awesome with something else. I may not have caught all places that font-awesome icons were being used. * We’ll want to make sure the post display is correct, including Hometown customizations, because the previous static post page has been replaced with the React one. --------- Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Matt Jankowski <matt@jankowski.online> Co-authored-by: Renaud Chaput <renchap@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Roetzel <david@roetzel.de> Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com> Co-authored-by: Jeong Arm <kjwonmail@gmail.com> Co-authored-by: Christian Schmidt <github@chsc.dk> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Darius Kazemi <darius.kazemi@gmail.com> Co-authored-by: diondiondion <mail@diondiondion.com> Co-authored-by: Echo <ChaosExAnima@users.noreply.github.com> Co-authored-by: Shugo Maeda <shugo.maeda@gmail.com> Co-authored-by: emilweth <7402764+emilweth@users.noreply.github.com> Co-authored-by: Shlee <github@shl.ee> Co-authored-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Co-authored-by: Jessica Stokes <hello@jessicastokes.net> Co-authored-by: PGray <77597544+PGrayCS@users.noreply.github.com>
3 weeks ago
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe 'Self-destruct mode' do
before do
allow(SelfDestructHelper).to receive(:self_destruct?).and_return(true)
end
shared_examples 'generic logged out request' do |path|
it 'returns 410 gone and mentions self-destruct' do
get path, headers: { 'Accept' => 'text/html' }
expect(response).to have_http_status(410)
expect(response.body).to include(I18n.t('self_destruct.title'))
end
end
shared_examples 'accessible logged-in endpoint' do |path|
it 'returns 200 ok' do
get path
expect(response).to have_http_status(200)
end
end
shared_examples 'ActivityPub request' do |path|
context 'without signature' do
it 'returns 410 gone' do
get path, headers: {
'Accept' => 'application/activity+json, application/ld+json; profile="https://www.w3.org/ns/activitystreams"',
}
expect(response).to have_http_status(410)
end
end
context 'with invalid signature' do
it 'returns 410 gone' do
get path, headers: {
'Accept' => 'application/activity+json, application/ld+json; profile="https://www.w3.org/ns/activitystreams"',
'Signature' => 'keyId="https://remote.domain/users/bob#main-key",algorithm="rsa-sha256",headers="date host (request-target)",signature="bar"',
}
expect(response).to have_http_status(410)
end
end
end
context 'when requesting various unavailable endpoints' do
it_behaves_like 'generic logged out request', '/'
it_behaves_like 'generic logged out request', '/about'
it_behaves_like 'generic logged out request', '/public'
end
context 'when requesting a suspended account' do
let(:suspended) { Fabricate(:account, username: 'suspended') }
before do
suspended.suspend!
end
it_behaves_like 'generic logged out request', '/@suspended'
it_behaves_like 'ActivityPub request', '/users/suspended'
it_behaves_like 'ActivityPub request', '/users/suspended/followers'
it_behaves_like 'ActivityPub request', '/users/suspended/outbox'
end
context 'when requesting a non-suspended account' do
before do
Fabricate(:account, username: 'bob')
end
it_behaves_like 'generic logged out request', '/@bob'
it_behaves_like 'ActivityPub request', '/users/bob'
it_behaves_like 'ActivityPub request', '/users/bob/followers'
it_behaves_like 'ActivityPub request', '/users/bob/outbox'
end
context 'when accessing still-enabled endpoints when logged in' do
let(:user) { Fabricate(:user) }
before do
sign_in(user)
end
it_behaves_like 'accessible logged-in endpoint', '/auth/edit'
it_behaves_like 'accessible logged-in endpoint', '/settings/export'
it_behaves_like 'accessible logged-in endpoint', '/settings/login_activities'
it_behaves_like 'accessible logged-in endpoint', '/settings/exports/follows.csv'
end
end