|
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
|
|
module Paperclip
|
|
|
|
|
# This transcoder is only to be used for the MediaAttachment model
|
|
|
|
|
# to check when uploaded videos are actually gifv's
|
|
|
|
|
class Transcoder < Paperclip::Processor
|
|
|
|
|
# This is the H.264 "High" value taken from https://www.dr-lex.be/info-stuff/videocalc.html
|
|
|
|
|
BITS_PER_PIXEL = 0.11
|
|
|
|
|
|
|
|
|
|
def initialize(file, options = {}, attachment = nil)
|
|
|
|
|
super
|
|
|
|
|
|
|
|
|
|
@current_format = File.extname(@file.path)
|
|
|
|
|
@basename = File.basename(@file.path, @current_format)
|
|
|
|
|
@format = options[:format]
|
|
|
|
|
@time = options[:time] || 3
|
|
|
|
|
@passthrough_options = options[:passthrough_options]
|
|
|
|
|
@convert_options = options[:convert_options].dup
|
|
|
|
|
@vfr_threshold = options[:vfr_frame_rate_threshold]
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def make
|
|
|
|
|
metadata = VideoMetadataExtractor.new(@file.path)
|
|
|
|
|
|
|
|
|
|
raise Paperclip::Error, "Error while transcoding #{@file.path}: unsupported file" unless metadata.valid?
|
|
|
|
|
|
|
|
|
|
update_attachment_type(metadata)
|
|
|
|
|
update_options_from_metadata(metadata)
|
|
|
|
|
|
|
|
|
|
destination = Tempfile.new([@basename, @format ? ".#{@format}" : ''])
|
|
|
|
|
destination.binmode
|
|
|
|
|
|
|
|
|
|
@output_options = @convert_options[:output]&.dup || {}
|
|
|
|
|
@input_options = @convert_options[:input]&.dup || {}
|
|
|
|
|
|
|
|
|
|
case @format.to_s
|
|
|
|
|
when /jpg$/, /jpeg$/, /png$/, /gif$/
|
|
|
|
|
@input_options['ss'] = @time
|
|
|
|
|
|
|
|
|
|
@output_options['f'] = 'image2'
|
|
|
|
|
@output_options['vframes'] = 1
|
|
|
|
|
when 'mp4'
|
|
|
|
|
unless eligible_to_passthrough?(metadata)
|
|
|
|
|
size_limit_in_bits = MediaAttachment::VIDEO_LIMIT * 8
|
|
|
|
|
desired_bitrate = (metadata.width * metadata.height * 30 * BITS_PER_PIXEL).floor
|
|
|
|
|
duration = [metadata.duration, 1].max
|
|
|
|
|
maximum_bitrate = (size_limit_in_bits / duration).floor - 192_000 # Leave some space for the audio stream
|
|
|
|
|
bitrate = [desired_bitrate, maximum_bitrate].min
|
|
|
|
|
|
|
|
|
|
@output_options['b:v'] = bitrate
|
|
|
|
|
@output_options['maxrate'] = bitrate + 192_000
|
|
|
|
|
@output_options['bufsize'] = bitrate * 5
|
|
|
|
|
|
|
|
|
|
if high_vfr?(metadata)
|
Bringing Hometown up to date with mastodon/mastodon (#1371)
This is a massive PR, so apologies for the poor performance viewing it!
This merges in the content of Mastodon 4.3.0. *This PR isn't ready to
deploy to production*, and I don't recommend trying it in a production
environment. Since I started by merging 4.3.0, this will likely have
reverted at least some of the content of the post-4.3.0 security patches
in the 4.2.x series; those will be brought back as I merge in 4.4.0 and
4.5.0.
I haven't yet tested this PR, so it may not actually run without
additional tweaks. I'm putting it up now for discussion and so multiple
people can test if we want.
---
Here's a few notes on things I ran into and thoughts I had while working
on it:
* We may want to look at `server_banner.jsx,` where I ended up undoing
the v3-style rewrite due to the new react component being used. I'm not
sure what the current goal for it is.
* I may not have 100% merged in all content from `status_action_bar`
correctly.
* There's a number of places where I updated the links for remote
usernames, and they should be tested to make sure they work. They're all
`<Permalink>` elements. I have in my notes that `status_content` might
need double-checking.
* I may also not have gotten the spoiler display right in
`status_content`.
* It looks like previous versions of Hometown had customizations to the
`media_item` display, not all of which was preserved as-is due to
surrounding rewrites. I'm not sure what the vision is and could use
another set of eyes.
* The character count rendering clashed with the newly-introduced
handling of a character count variable upstream, and I'm not sure if the
version I've got here 100% works or not.
* The navigation bar was completely rewritten and no longer has the
components Hometown was customizing; did I properly catch any
replacements? Did we handle all links to accounts to make sure they go
to the remote instance?
* Polls: I reverted the single/multiple choice toggle because upstream
has an actual proper UI for this that should be integrated in one of the
versions we’re merging in. Please double-check that the current version
looks fine to you.
* The font icons will need double-checking. Hometown made some custom
use of the font-awesome icons, while Mastodon 4.3.0 replaced
font-awesome with something else. I may not have caught all places that
font-awesome icons were being used.
* We’ll want to make sure the post display is correct, including
Hometown customizations, because the previous static post page has been
replaced with the React one.
---------
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Matt Jankowski <matt@jankowski.online>
Co-authored-by: Renaud Chaput <renchap@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Roetzel <david@roetzel.de>
Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: Christian Schmidt <github@chsc.dk>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Darius Kazemi <darius.kazemi@gmail.com>
Co-authored-by: diondiondion <mail@diondiondion.com>
Co-authored-by: Echo <ChaosExAnima@users.noreply.github.com>
Co-authored-by: Shugo Maeda <shugo.maeda@gmail.com>
Co-authored-by: emilweth <7402764+emilweth@users.noreply.github.com>
Co-authored-by: Shlee <github@shl.ee>
Co-authored-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
Co-authored-by: Jessica Stokes <hello@jessicastokes.net>
Co-authored-by: PGray <77597544+PGrayCS@users.noreply.github.com>
3 weeks ago
|
|
|
# TODO: change to `fps_mode` in the future, as `vsync` is being deprecated
|
|
|
|
|
@output_options['vsync'] = 'vfr'
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
command_arguments, interpolations = prepare_command(destination)
|
|
|
|
|
|
|
|
|
|
begin
|
|
|
|
|
command = Terrapin::CommandLine.new(Rails.configuration.x.ffmpeg_binary, command_arguments.join(' '), logger: Paperclip.logger)
|
|
|
|
|
command.run(interpolations)
|
|
|
|
|
rescue Terrapin::ExitStatusError => e
|
|
|
|
|
raise Paperclip::Error, "Error while transcoding #{@basename}: #{e}"
|
|
|
|
|
rescue Terrapin::CommandNotFoundError
|
|
|
|
|
raise Paperclip::Errors::CommandNotFoundError, 'Could not run the `ffmpeg` command. Please install ffmpeg.'
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
destination
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
|
|
def prepare_command(destination)
|
|
|
|
|
command_arguments = ['-nostdin']
|
|
|
|
|
interpolations = {}
|
|
|
|
|
interpolation_keys = 0
|
|
|
|
|
|
|
|
|
|
@input_options.each_pair do |key, value|
|
|
|
|
|
interpolation_key = interpolation_keys
|
|
|
|
|
command_arguments << "-#{key} :#{interpolation_key}"
|
|
|
|
|
interpolations[interpolation_key] = value
|
|
|
|
|
interpolation_keys += 1
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
command_arguments << '-i :source'
|
|
|
|
|
interpolations[:source] = @file.path
|
|
|
|
|
|
|
|
|
|
@output_options.each_pair do |key, value|
|
|
|
|
|
interpolation_key = interpolation_keys
|
|
|
|
|
command_arguments << "-#{key} :#{interpolation_key}"
|
|
|
|
|
interpolations[interpolation_key] = value
|
|
|
|
|
interpolation_keys += 1
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
command_arguments << '-y :destination'
|
|
|
|
|
interpolations[:destination] = destination.path
|
|
|
|
|
|
|
|
|
|
[command_arguments, interpolations]
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def update_options_from_metadata(metadata)
|
|
|
|
|
return unless eligible_to_passthrough?(metadata)
|
|
|
|
|
|
|
|
|
|
@format = @passthrough_options[:options][:format] || @format
|
|
|
|
|
@time = @passthrough_options[:options][:time] || @time
|
|
|
|
|
@convert_options = @passthrough_options[:options][:convert_options].dup
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def high_vfr?(metadata)
|
|
|
|
|
@vfr_threshold && metadata.r_frame_rate && metadata.r_frame_rate > @vfr_threshold
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def eligible_to_passthrough?(metadata)
|
|
|
|
|
@passthrough_options && @passthrough_options[:video_codecs].include?(metadata.video_codec) && @passthrough_options[:audio_codecs].include?(metadata.audio_codec) && @passthrough_options[:colorspaces].include?(metadata.colorspace)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def update_attachment_type(metadata)
|
|
|
|
|
@attachment.instance.type = MediaAttachment.types[:gifv] unless metadata.audio_codec
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|