Don't start adb on search unless strictly necessary

cmd/fdroidcl/devices.go

@@ -40,22 +40,14 @@ func startAdbIfNeeded() {
 	}
 }
 
-func maybeOneDevice() *adb.Device {
+func mustOneDevice() *adb.Device {
 	startAdbIfNeeded()
 	devices, err := adb.Devices()
 	if err != nil {
 		log.Fatalf("Could not get devices: %v", err)
 	}
 	if len(devices) != 1 {
-		return nil
-	}
-	return devices[0]
-}
-
-func mustOneDevice() *adb.Device {
-	device := maybeOneDevice()
-	if device == nil {
 		log.Fatalf("Exactly one connected device is needed")
 	}
-	return device
+	return devices[0]
 }

cmd/fdroidcl/search.go

@@ -36,8 +36,6 @@ func runSearch(args []string) {
 	var device *adb.Device
 	if *installed || *updates {
 		device = mustOneDevice()
-	} else {
-		device = maybeOneDevice()
 	}
 	index := mustLoadIndex()
 	apps := filterAppsSearch(index.Apps, args)