From 58621aa0df1c3c3e874825f3c1af516355b0da87 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Thu, 7 Jun 2018 14:28:09 +0100
Subject: [PATCH] cmd/fdroidcl: install, upgrade, uninstall tests

---
 cmd/fdroidcl/endtoend_test.go | 57 +++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/cmd/fdroidcl/endtoend_test.go b/cmd/fdroidcl/endtoend_test.go
index 2d3576a..81d4740 100644
--- a/cmd/fdroidcl/endtoend_test.go
+++ b/cmd/fdroidcl/endtoend_test.go
@@ -4,6 +4,7 @@
 package main
 
 import (
+	"bytes"
 	"io/ioutil"
 	"net/http"
 	"os"
@@ -14,6 +15,14 @@ import (
 	"time"
 )
 
+// chosenApp is the app that will be installed and uninstalled on a connected
+// device. This one was chosen because it's tiny, requires no permissions, and
+// should be compatible with every device.
+//
+// It also stores no data, so it is fine to uninstall it and the user won't lose
+// any data.
+const chosenApp = "org.vi_server.red_screen"
+
 func TestEndToEnd(t *testing.T) {
 	url := config.Repos[0].URL
 	client := http.Client{Timeout: 2 * time.Second}
@@ -74,6 +83,52 @@ func TestEndToEnd(t *testing.T) {
 	t.Run("SearchOnlyPackageNames", func(t *testing.T) {
 		mustSucceed(t, `^[^ ]*$`, "search", "-q", "fdroid.fdroid")
 	})
+
+	t.Run("ShowOne", func(t *testing.T) {
+		mustSucceed(t, `fdroid/fdroidclient`, "show", "org.fdroid.fdroid")
+	})
+	t.Run("ShowMany", func(t *testing.T) {
+		mustSucceed(t, `fdroid/fdroidclient.*fdroid/privileged-extension`,
+			"show", "org.fdroid.fdroid", "org.fdroid.fdroid.privileged")
+	})
+
+	t.Run("ListCategories", func(t *testing.T) {
+		mustSucceed(t, `Development`, "list", "categories")
+	})
+
+	out, err := exec.Command(fdroidcl, "devices").CombinedOutput()
+	if err != nil {
+		t.Fatal(err)
+	}
+	switch bytes.Count(out, []byte("\n")) {
+	case 0:
+		t.Log("skipping the device tests as none was found via ADB")
+	case 1:
+		// continue below
+	default:
+		t.Log("skipping the device tests as too many were found via ADB")
+	}
+
+	// try to uninstall the app first
+	exec.Command(fdroidcl, "uninstall", chosenApp).Run()
+	t.Run("UninstallMissing", func(t *testing.T) {
+		mustFail(t, `not installed$`, "uninstall", chosenApp)
+	})
+	t.Run("InstallVersioned", func(t *testing.T) {
+		mustSucceed(t, `Installing `+regexp.QuoteMeta(chosenApp),
+			"install", chosenApp+":1")
+	})
+	t.Run("Upgrade", func(t *testing.T) {
+		mustSucceed(t, `Upgrading `+regexp.QuoteMeta(chosenApp),
+			"upgrade", chosenApp)
+	})
+	t.Run("UpgradeAlreadyInstalled", func(t *testing.T) {
+		mustFail(t, `is up to date$`, "upgrade", chosenApp)
+	})
+	t.Run("UninstallExisting", func(t *testing.T) {
+		mustSucceed(t, `Uninstalling `+regexp.QuoteMeta(chosenApp),
+			"uninstall", chosenApp)
+	})
 }
 
 func mustRun(t *testing.T, success bool, wantRe, name string, args ...string) {
@@ -84,6 +139,8 @@ func mustRun(t *testing.T, success bool, wantRe, name string, args ...string) {
 	} else if !success && err == nil {
 		t.Fatalf("expected error, got none\n%s", out)
 	}
+	// Let '.' match newlines, and treat the output as a single line.
+	wantRe = "(?sm)" + wantRe
 	if !regexp.MustCompile(wantRe).Match(out) {
 		t.Fatalf("output does not match %#q:\n%s", wantRe, out)
 	}