Remove basedir implementation

Go added native support for finding the config directory via
`os.UserConfigDir()`, so no need for a custom implementation with the
potantial of becomming outdated/wrong over time.

basedir/basedir.go

@@ -1,35 +0,0 @@
-// Copyright (c) 2015, Daniel Martí <mvdan@mvdan.cc>
-// See LICENSE for licensing information
-
-package basedir
-
-import (
-	"os"
-	"os/user"
-	"path/filepath"
-)
-
-// TODO: replace with https://github.com/golang/go/issues/29960 if accepted.
-
-// Data returns the base data directory.
-func Data() string {
-	return dataDir
-}
-
-func firstGetenv(def string, evs ...string) string {
-	for _, ev := range evs {
-		if v := os.Getenv(ev); v != "" {
-			return v
-		}
-	}
-	// TODO: replace with os.UserHomeDir once we require Go 1.12 or later.
-	home := os.Getenv("HOME")
-	if home == "" {
-		curUser, err := user.Current()
-		if err != nil {
-			return ""
-		}
-		home = curUser.HomeDir
-	}
-	return filepath.Join(home, def)
-}

basedir/basedir_darwin.go

@@ -1,6 +0,0 @@
-// Copyright (c) 2015, Daniel Martí <mvdan@mvdan.cc>
-// See LICENSE for licensing information
-
-package basedir
-
-var dataDir = firstGetenv("Library/Application Support")

basedir/basedir_unix.go

@@ -1,8 +0,0 @@
-// Copyright (c) 2015, Daniel Martí <mvdan@mvdan.cc>
-// See LICENSE for licensing information
-
-// +build dragonfly freebsd linux netbsd openbsd
-
-package basedir
-
-var dataDir = firstGetenv(".config", "XDG_CONFIG_HOME")

basedir/basedir_windows.go

@@ -1,6 +0,0 @@
-// Copyright (c) 2015, Daniel Martí <mvdan@mvdan.cc>
-// See LICENSE for licensing information
-
-package basedir
-
-var dataDir = firstGetenv("", "APPDATA")

main.go

@@ -10,8 +10,6 @@ import (
 	"os"
 	"path/filepath"
 	"strings"
-
-	"mvdan.cc/fdroidcl/basedir"
 )
 
 const cmdName = "fdroidcl"
@@ -36,9 +34,9 @@ func mustCache() string {
 }
 
 func mustData() string {
-	dir := basedir.Data()
+	dir, err := os.UserConfigDir()
-	if dir == "" {
+	if err != nil {
-		fmt.Fprintln(os.Stderr, "Could not determine data dir")
+		fmt.Fprintln(os.Stderr, err)
 		panic("TODO: return an error")
 	}
 	return subdir(dir, cmdName)