From 3ca06a6adf3ef616b287d08c6d5a2cdab1ee6c0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sun, 14 Feb 2016 23:03:04 +0000 Subject: [PATCH] Remove redundant UnmarshalXML code We are already covered by the much simpler UnmarshalXML code. --- fieldtypes.go | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/fieldtypes.go b/fieldtypes.go index 53bcc8b..b2036da 100644 --- a/fieldtypes.go +++ b/fieldtypes.go @@ -5,7 +5,6 @@ package fdroidcl import ( "encoding/hex" - "encoding/xml" "strings" "time" ) @@ -20,15 +19,6 @@ func (cl *CommaList) String() string { return strings.Join(*cl, ",") } -func (cl *CommaList) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error { - var content string - if err := d.DecodeElement(&content, &start); err != nil { - return err - } - cl.FromString(content) - return nil -} - func (cl *CommaList) UnmarshalText(text []byte) (err error) { cl.FromString(string(text)) return nil @@ -54,14 +44,6 @@ func (hv *HexVal) String() string { return hex.EncodeToString(*hv) } -func (hv *HexVal) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error { - var content string - if err := d.DecodeElement(&content, &start); err != nil { - return err - } - return hv.FromString(content) -} - func (hv *HexVal) UnmarshalText(text []byte) (err error) { return hv.FromString(string(text)) } @@ -83,14 +65,6 @@ func (dv *DateVal) String() string { return dv.Format("2006-01-02") } -func (dv *DateVal) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error { - var content string - if err := d.DecodeElement(&content, &start); err != nil { - return err - } - return dv.FromString(content) -} - func (dv *DateVal) UnmarshalText(text []byte) (err error) { return dv.FromString(string(text)) }