From e2ce0b6fca1c52488f32e5e3102325ec253fb623 Mon Sep 17 00:00:00 2001 From: Maksim Nabokikh Date: Thu, 16 Feb 2023 21:40:05 +0400 Subject: [PATCH] chore: Add a comment about config/email JSON tag bug (#2830) Signed-off-by: m.nabokikh --- storage/storage.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/storage/storage.go b/storage/storage.go index c77c1917..0009d4b1 100644 --- a/storage/storage.go +++ b/storage/storage.go @@ -368,6 +368,10 @@ type Connector struct { ResourceVersion string `json:"resourceVersion"` // Config holds all the configuration information specific to the connector type. Since there // no generic struct we can use for this purpose, it is stored as a byte stream. + // + // NOTE: This is a bug. The JSON tag should be `config`. + // However, fixing this requires migrating Kubernetes objects for all previously created connectors, + // or making Dex reading both tags and act accordingly. Config []byte `json:"email"` }