Browse Source

Clarification of C++ standard usage (#4839)

pull/4831/head
Mikołaj Piróg 4 years ago committed by GitHub
parent
commit
fd3baddbc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      CMakeLists.txt
  2. 5
      docs/CONTRIBUTING.md

3
CMakeLists.txt

@ -240,6 +240,9 @@ if(GPERF)
endif()
endif()
# Despite setting C++ standard to 20, features from this version are not being used.
# The oldest compiler used is GCC 6.5 - and that defines our C++ feature set (meaning most of C++17).
# It's present only to take advantage of fmt::format build time errors.
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_CXX_STANDARD_REQUIRED OFF)

5
docs/CONTRIBUTING.md

@ -3,6 +3,11 @@
This guide outlines useful resources, tools and processes for contribution to
DevilutionX.
## C++ Standard
Despite setting C++ standard to 20 in CMakeLists.txt, features from this version are not being used.
The oldest compiler used is GCC 6.5 - and that defines our C++ feature set (meaning most of C++17).
It's present only to take advantage of fmt::format build time errors.
## Code style guide
[The code style guide](https://github.com/diasurgical/devilutionX/wiki/Code-Style) is evolving with the project.

Loading…
Cancel
Save