From 5985e2e5a217321631a04496869af43705797c71 Mon Sep 17 00:00:00 2001 From: Anders Jenbo Date: Sat, 30 Mar 2019 17:19:10 +0100 Subject: [PATCH 1/2] Clena up AddWeapexp --- Source/missiles.cpp | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/Source/missiles.cpp b/Source/missiles.cpp index a831f9cd8..4058782a2 100644 --- a/Source/missiles.cpp +++ b/Source/missiles.cpp @@ -1855,23 +1855,20 @@ void __fastcall AddMisexp(int mi, int sx, int sy, int dx, int dy, int midir, cha void __fastcall AddWeapexp(int mi, int sx, int sy, int dx, int dy, int midir, char mienemy, int id, int dam) { - int v9; // esi - - v9 = mi; - missile[v9]._miy = sy; - missile[v9]._misy = sy; - missile[v9]._mix = sx; - missile[v9]._misx = sx; - missile[v9]._mixvel = 0; - missile[v9]._miyvel = 0; - missile[v9]._miVar1 = 0; - missile[v9]._miVar2 = dx; - missile[v9]._mimfnum = 0; + missile[mi]._mix = sx; + missile[mi]._miy = sy; + missile[mi]._misx = sx; + missile[mi]._misy = sy; + missile[mi]._mixvel = 0; + missile[mi]._miyvel = 0; + missile[mi]._miVar1 = 0; + missile[mi]._miVar2 = dx; + missile[mi]._mimfnum = 0; if (dx == 1) SetMissAnim(mi, MFILE_MAGBLOS); else SetMissAnim(mi, MFILE_MINILTNG); - missile[v9]._mirange = missile[v9]._miAnimLen - 1; + missile[mi]._mirange = missile[mi]._miAnimLen - 1; } BOOL __fastcall CheckIfTrig(int x, int y) From f71347471a1c87f958b4a15ed8a0b3eb456b612b Mon Sep 17 00:00:00 2001 From: Anders Jenbo Date: Sat, 30 Mar 2019 17:36:13 +0100 Subject: [PATCH 2/2] Clean up AddFiremove --- Source/missiles.cpp | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/Source/missiles.cpp b/Source/missiles.cpp index 4058782a2..25beff49a 100644 --- a/Source/missiles.cpp +++ b/Source/missiles.cpp @@ -457,14 +457,16 @@ int __fastcall FindClosest(int sx, int sy, int rad) int __fastcall GetSpellLevel(int id, int sn) { - int result; // eax + int result; if (id == myplr) result = plr[id]._pISplLvlAdd + plr[id]._pSplLvl[sn]; else result = 1; + if (result < 0) result = 0; + return result; } @@ -1999,22 +2001,14 @@ void __fastcall AddManashield(int mi, int sx, int sy, int dx, int dy, int midir, void __fastcall AddFiremove(int mi, int sx, int sy, int dx, int dy, int midir, char mienemy, int id, int dam) { - int v9; // edi - int v10; // ebx - int v11; // esi - - v9 = mi; - v10 = sx; - v11 = mi; - v11 *= 176; - *(int *)((char *)&missile[0]._midam + v11) = random(59, 10) + plr[id]._pLevel + 1; - GetMissileVel(v9, v10, sy, dx, dy, 16); - *(int *)((char *)&missile[0]._miVar1 + v11) = 0; - *(int *)((char *)&missile[0]._miVar2 + v11) = 0; - ++*(int *)((char *)&missile[0]._mix + v11); - ++*(int *)((char *)&missile[0]._miy + v11); - *(int *)((char *)&missile[0]._miyoff + v11) -= 32; - *(int *)((char *)&missile[0]._mirange + v11) = 255; + missile[mi]._midam = random(59, 10) + plr[id]._pLevel + 1; + GetMissileVel(mi, sx, sy, dx, dy, 16); + missile[mi]._mirange = 255; + missile[mi]._miVar1 = 0; + missile[mi]._miVar2 = 0; + missile[mi]._mix++; + missile[mi]._miy++; + missile[mi]._miyoff -= 32; } void __fastcall AddGuardian(int mi, int sx, int sy, int dx, int dy, int midir, char mienemy, int id, int dam)