From bf493d8b58c133521e49f7bb3b7ecb23ff15b3f2 Mon Sep 17 00:00:00 2001 From: Gleb Mazovetskiy Date: Thu, 10 Oct 2019 07:08:15 +0100 Subject: [PATCH] Fix UB: pointer overflow gmenu.cpp:112 --- Source/gmenu.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/gmenu.cpp b/Source/gmenu.cpp index 7422c1a31..b64638fce 100644 --- a/Source/gmenu.cpp +++ b/Source/gmenu.cpp @@ -109,7 +109,7 @@ void gmenu_call_proc(TMenuItem *pItem, void (*gmFunc)(TMenuItem *)) sgCurrentMenuIdx++; } } - sgpCurrItem = &sgpCurrentMenu[sgCurrentMenuIdx - 1]; + sgpCurrItem = sgCurrentMenuIdx > 0 ? &sgpCurrentMenu[sgCurrentMenuIdx - 1] : nullptr; gmenu_up_down(TRUE); } @@ -386,7 +386,7 @@ void gmenu_slider_set(TMenuItem *pItem, int min, int max, int value) } /** - * @brief Get the current value for the slider + * @brief Get the current value for the slider */ int gmenu_slider_get(TMenuItem *pItem, int min, int max) {