From 5ae0e5eb17d2fcd809f38d79bac0efe60249e42d Mon Sep 17 00:00:00 2001
From: Eric Robinson <68359262+kphoenix137@users.noreply.github.com>
Date: Fri, 26 Jul 2024 02:01:46 -0400
Subject: [PATCH] Optimize DeadItem() (#7213)

Optimize DeadItem() - Look up `player.position.tile` only once.
---
 Source/player.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Source/player.cpp b/Source/player.cpp
index 45fb5e26d..7f21af54e 100644
--- a/Source/player.cpp
+++ b/Source/player.cpp
@@ -307,7 +307,9 @@ void DeadItem(Player &player, Item &&itm, Displacement direction)
 	if (itm.isEmpty())
 		return;
 
-	Point target = player.position.tile + direction;
+	const Point playerTile = player.position.tile;
+	const Point target = playerTile + direction;
+
 	if (direction != Displacement { 0, 0 } && ItemSpaceOk(target)) {
 		RespawnDeadItem(std::move(itm), target);
 		return;
@@ -316,7 +318,7 @@ void DeadItem(Player &player, Item &&itm, Displacement direction)
 	for (int k = 1; k < 50; k++) {
 		for (int j = -k; j <= k; j++) {
 			for (int i = -k; i <= k; i++) {
-				Point next = player.position.tile + Displacement { i, j };
+				Point next = playerTile + Displacement { i, j };
 				if (ItemSpaceOk(next)) {
 					RespawnDeadItem(std::move(itm), next);
 					return;