the big PR of the day

Source/diablo.cpp

@@ -1024,22 +1024,28 @@ BOOL PressSysKey(int wParam)
 	return TRUE;
 }
 
-void diablo_hotkey_msg(int dwMsg)
+void diablo_hotkey_msg(DWORD dwMsg)
 {
-	char Filename[MAX_PATH];
+	char *s;
-	char ReturnedString[MAX_SEND_STR_LEN];
+	char szFileName[MAX_PATH];
-	char *separator;
+	char szMsg[MAX_SEND_STR_LEN];
-
+
-	if (gbMaxPlayers != 1) {
+	if(gbMaxPlayers == 1) {
-		if (!GetModuleFileName(ghInst, Filename, sizeof(Filename)))
+		return;
-			app_fatal("Can't get program name");
+	}
-		separator = strrchr(Filename, '\\');
+	if(GetModuleFileName(ghInst, szFileName, sizeof(szFileName)) == 0) {
-		if (separator)
+		app_fatal("Can't get program name");
-			*separator = '\0';
-		strcat(Filename, "\\Diablo.ini");
-		GetPrivateProfileString("NetMsg", spszMsgKeyTbl[dwMsg], spszMsgTbl[dwMsg], ReturnedString, sizeof(ReturnedString), Filename);
-		NetSendCmdString(-1, ReturnedString);
 	}
+
+	s = strrchr(szFileName, '\\');
+	if(s != NULL) {
+		*s = '\0';
+	}
+
+	strcat(szFileName, "\\Diablo.ini");
+	/// ASSERT: assert(dwMsg < sizeof(spszMsgTbl) / sizeof(spszMsgTbl[0]));
+	GetPrivateProfileString("NetMsg", spszMsgKeyTbl[dwMsg], spszMsgTbl[dwMsg], szMsg, sizeof(szMsg), szFileName);
+	NetSendCmdString(-1, szMsg);
 }
 // 48436C: using guessed type char *spszMsgTbl[4];
 // 48437C: using guessed type char *spszMsgKeyTbl[4];

Source/diablo.h

@@ -54,7 +54,7 @@ void LeftMouseUp();
 void RightMouseDown();
 void j_gmenu_on_mouse_move(LPARAM lParam);
 BOOL PressSysKey(int wParam);
-void diablo_hotkey_msg(int dwMsg);
+void diablo_hotkey_msg(DWORD dwMsg);
 void ReleaseKey(int vkey);
 void PressKey(int vkey);
 void diablo_pause_game();