From 3ad49d59a6f7a956a60765c7f142e984f29f18c3 Mon Sep 17 00:00:00 2001 From: Gleb Mazovetskiy Date: Sun, 28 Nov 2021 09:19:30 +0000 Subject: [PATCH] selhero.cpp: Fix `-Wpessimizing-move` Source/DiabloUI/selhero.cpp:488:27: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] --- Source/DiabloUI/selhero.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/DiabloUI/selhero.cpp b/Source/DiabloUI/selhero.cpp index edb627935..6ae5eab1d 100644 --- a/Source/DiabloUI/selhero.cpp +++ b/Source/DiabloUI/selhero.cpp @@ -485,7 +485,7 @@ void selhero_List_Init() vecSelDlgItems.push_back(std::make_unique(vecSelHeroDlgItems, 6, PANEL_LEFT + 265, (UI_OFFSET_Y + 256), 320, 26, UiFlags::AlignCenter | UiFlags::FontSize24 | UiFlags::ColorUiGold)); SDL_Rect rect2 = { (Sint16)(PANEL_LEFT + 585), (Sint16)(UI_OFFSET_Y + 244), 25, 178 }; - vecSelDlgItems.push_back(std::move(std::make_unique(&ArtScrollBarBackground, &ArtScrollBarThumb, &ArtScrollBarArrow, rect2))); + vecSelDlgItems.push_back(std::make_unique(&ArtScrollBarBackground, &ArtScrollBarThumb, &ArtScrollBarArrow, rect2)); SDL_Rect rect3 = { (Sint16)(PANEL_LEFT + 239), (Sint16)(UI_OFFSET_Y + 429), 120, 35 }; vecSelDlgItems.push_back(std::make_unique(_("OK"), &UiFocusNavigationSelect, rect3, UiFlags::AlignCenter | UiFlags::FontSize30 | UiFlags::ColorUiGold));