From 0bc39eb250b2cef8bedd8dd3aac7b6b4720e240a Mon Sep 17 00:00:00 2001 From: Robin Eklind Date: Sun, 16 Sep 2018 20:16:38 +0200 Subject: [PATCH] Remove container after use in contrib for devilution-comparer --- Support/CONTRIBUTING.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Support/CONTRIBUTING.md b/Support/CONTRIBUTING.md index 28347a83c..226f54058 100644 --- a/Support/CONTRIBUTING.md +++ b/Support/CONTRIBUTING.md @@ -152,20 +152,17 @@ If not on Windows Devilution-comparer requires Wine, either install Wine or use * Step 5: To get a function for comparison Build: -`docker run -ti -v $(pwd):/root/devilution -e MAKE_BUILD=pdb diasurgical/riivaaja` +`docker run --rm -ti -v $(pwd):/root/devilution -e MAKE_BUILD=pdb diasurgical/riivaaja` Generate diff: `devilution-comparer Diablo_original.exe Diablo.exe ` You can add `--no-mem-disp` if you want a cleaner output but this can also hide valuable details This will generate a `orig.asm` and `compare.asm` that you can compare in your favorit `diff` application, in the folder that you can the command from. -Note: A note on `docker run`, it will currently leave behind an image each time you run the command and may eventually exhaust your disk space, to reclaim the space you can run the following command: -`docker system prune` - To use riivaaja as instead of installing Wine create wine in your `$PATH` and add this content: ```bash #!/bin/sh -docker run -v $(pwd):/root/devilution --entrypoint "/usr/bin/wine" diasurgical/riivaaja:stable $(basename $1) $2 $3 +docker run --rm -v $(pwd):/root/devilution --entrypoint "/usr/bin/wine" diasurgical/riivaaja:stable $(basename $1) $2 $3 ``` (Don't forget to also set exec permissions on the file)