From 02dc1f193ec732c57132405d81ea37e7fa3329e2 Mon Sep 17 00:00:00 2001 From: KPhoenix <68359262+kphoenix137@users.noreply.github.com> Date: Thu, 6 Jan 2022 04:04:14 -0500 Subject: [PATCH] Cleanup missiles.cpp (#3883) --- Source/missiles.cpp | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/Source/missiles.cpp b/Source/missiles.cpp index 55ef3223d..f851fd0ea 100644 --- a/Source/missiles.cpp +++ b/Source/missiles.cpp @@ -2820,8 +2820,9 @@ void MI_LArrow(Missile &missile) int mind; int maxd; if (p != -1) { - mind = Players[p]._pILMinDam; - maxd = Players[p]._pILMaxDam; + auto &player = Players[p]; + mind = player._pILMinDam; + maxd = player._pILMaxDam; } else { mind = GenerateRnd(10) + 1 + currlevel; maxd = GenerateRnd(10) + 1 + currlevel * 2; @@ -2833,8 +2834,9 @@ void MI_LArrow(Missile &missile) int mind; int maxd; if (p != -1) { - mind = Players[p]._pIFMinDam; - maxd = Players[p]._pIFMaxDam; + auto &player = Players[p]; + mind = player._pIFMinDam; + maxd = player._pIFMaxDam; } else { mind = GenerateRnd(10) + 1 + currlevel; maxd = GenerateRnd(10) + 1 + currlevel * 2; @@ -2850,11 +2852,13 @@ void MI_LArrow(Missile &missile) int maxd; if (p != -1) { if (missile._micaster == TARGET_MONSTERS) { - mind = Players[p]._pIMinDam; - maxd = Players[p]._pIMaxDam; + auto &player = Players[p]; + mind = player._pIMinDam; + maxd = player._pIMaxDam; } else { - mind = Monsters[p].mMinDamage; - maxd = Monsters[p].mMaxDamage; + auto &monster = Monsters[p]; + mind = monster.mMinDamage; + maxd = monster.mMaxDamage; } } else { mind = GenerateRnd(10) + 1 + currlevel; @@ -2899,11 +2903,13 @@ void MI_Arrow(Missile &missile) int maxd; if (p != -1) { if (missile._micaster == TARGET_MONSTERS) { - mind = Players[p]._pIMinDam; - maxd = Players[p]._pIMaxDam; + auto &player = Players[p]; + mind = player._pIMinDam; + maxd = player._pIMaxDam; } else { - mind = Monsters[p].mMinDamage; - maxd = Monsters[p].mMaxDamage; + auto &monster = Monsters[p]; + mind = monster.mMinDamage; + maxd = monster.mMaxDamage; } } else { mind = currlevel;