mirror
/
devilutionX
mirror of https://github.com/diasurgical/devilutionX.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
11952 Commits
44 Branches
22 Tags
292 MiB
Branch: master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'master'
${ noResults }
devilutionX/CMake/VcPkgManifestFeatures.cmake

18 lines
506 B
Raw Permalink Normal View History Unescape

Overhaul dependency options Changes how dependency options are handled and moves them out of `CMakeLists.txt`. Major changes: 1. The static default now takes `TARGET_SUPPORTS_SHARED_LIBS` into account 2. The `DIST` setting no longer affects the static default. 3. The static option is now visible for system dependencies as well. (it was previously hidden by `cmake_dependent_option`). 4. The auto-detection mechanism for `libfmt` and `SDL_image` only applies if the setting has not been set. 5. SDL2 on Android is now also linked statically, resulting in a 1.1 MiB smaller APK. When using non-system dependencies, the default should always be static, as there are 2 main use cases for these: 1. Dependencies that we must currently vendor because our forks have significant changes that are not yet merged/released upstream. 2. Platforms that have no system packages, such as Android and iOS. In both cases, static linking is the most appropriate default.
4 years ago
# See https://vcpkg.readthedocs.io/en/latest/users/manifests/
if(USE_SDL1)
list(APPEND VCPKG_MANIFEST_FEATURES "sdl1")
Add USE_SDL3 build option This does not actually add SDL3 support but adds enough CMake stuff to make the following succeed: ```bash cmake -S. -Bbuild-sdl3 -DUSE_SDL3=ON -DDEVILUTIONX_SYSTEM_SDL3=OFF -DDEVILUTIONX_STATIC_SDL3=ON -DNOSOUND=ON ``` `NOSOUND` is needed because `SDL_audiolib` does not support SDL3.
5 months ago
elseif(USE_SDL3)
list(APPEND VCPKG_MANIFEST_FEATURES "sdl3")
Overhaul dependency options Changes how dependency options are handled and moves them out of `CMakeLists.txt`. Major changes: 1. The static default now takes `TARGET_SUPPORTS_SHARED_LIBS` into account 2. The `DIST` setting no longer affects the static default. 3. The static option is now visible for system dependencies as well. (it was previously hidden by `cmake_dependent_option`). 4. The auto-detection mechanism for `libfmt` and `SDL_image` only applies if the setting has not been set. 5. SDL2 on Android is now also linked statically, resulting in a 1.1 MiB smaller APK. When using non-system dependencies, the default should always be static, as there are 2 main use cases for these: 1. Dependencies that we must currently vendor because our forks have significant changes that are not yet merged/released upstream. 2. Platforms that have no system packages, such as Android and iOS. In both cases, static linking is the most appropriate default.
4 years ago
else()
list(APPEND VCPKG_MANIFEST_FEATURES "sdl2")
endif()
if(PACKET_ENCRYPTION)
list(APPEND VCPKG_MANIFEST_FEATURES "encryption")
endif()
if(USE_GETTEXT_FROM_VCPKG)
list(APPEND VCPKG_MANIFEST_FEATURES "translations")
endif()
Overhaul tests 1. Adds a `libdevilution_so` target when tests are enabled. 2. Each test file is now a separate binary target linked against `libdevilutionx_so` (can now run tests in parallel). 3. Tests are now defined in a separate `test/CMakeLists.txt` file. 4. Building the tests is now controlled by the standard `BUILD_TESTING` option (defined by CTest). 5. Tests are now built by default. 6. On CI, test errors are now reported. Also: * `.clang-format`: Enable SortIncludes in tests * `path_test.cpp`: Fix -Wsign-compare
4 years ago
if(BUILD_TESTING)
Overhaul dependency options Changes how dependency options are handled and moves them out of `CMakeLists.txt`. Major changes: 1. The static default now takes `TARGET_SUPPORTS_SHARED_LIBS` into account 2. The `DIST` setting no longer affects the static default. 3. The static option is now visible for system dependencies as well. (it was previously hidden by `cmake_dependent_option`). 4. The auto-detection mechanism for `libfmt` and `SDL_image` only applies if the setting has not been set. 5. SDL2 on Android is now also linked statically, resulting in a 1.1 MiB smaller APK. When using non-system dependencies, the default should always be static, as there are 2 main use cases for these: 1. Dependencies that we must currently vendor because our forks have significant changes that are not yet merged/released upstream. 2. Platforms that have no system packages, such as Android and iOS. In both cases, static linking is the most appropriate default.
4 years ago
list(APPEND VCPKG_MANIFEST_FEATURES "tests")
endif()