mirror
/
devilutionX
mirror of https://github.com/diasurgical/devilutionX.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
11961 Commits
44 Branches
22 Tags
292 MiB
Branch: access
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'access'
${ noResults }
devilutionX/Source/utils/attributes.h

129 lines
3.2 KiB
Raw Permalink Normal View History Unescape

🧹 Add and use a DVL_ALWAYS_INLINE macro Also moves attribute macros out of miniwin into a new header.
5 years ago
/**
* @file attributes.h
*
* Macros for attributes on functions, variables, etc.
*/
#pragma once
#ifdef __has_attribute
#define DVL_HAVE_ATTRIBUTE(x) __has_attribute(x)
#else
#define DVL_HAVE_ATTRIBUTE(x) 0
#endif
Async load: Handle errors
1 year ago
#ifdef __has_builtin
#define DVL_HAVE_BUILTIN(x) __has_builtin(x)
#else
#define DVL_HAVE_BUILTIN(x) 0
#endif
🧹 Add and use a DVL_ALWAYS_INLINE macro Also moves attribute macros out of miniwin into a new header.
5 years ago
#if DVL_HAVE_ATTRIBUTE(format) || (defined(__GNUC__) && !defined(__clang__))
#define DVL_PRINTF_ATTRIBUTE(fmtargnum, firstarg) \
__attribute__((__format__(__printf__, fmtargnum, firstarg)))
#else
#define DVL_PRINTF_ATTRIBUTE(fmtargnum, firstarg)
#endif
Fix a few more warnings The pure attribute on `StaticVector#empty` is needed so that it can be used in `DVL_ASSUME` without a warning about side-effects in assume.
2 years ago
#if DVL_HAVE_ATTRIBUTE(pure)
#define DVL_PURE __attribute__((pure))
#else
#define DVL_PURE
#endif
🧹 Add and use a DVL_ALWAYS_INLINE macro Also moves attribute macros out of miniwin into a new header.
5 years ago
#if DVL_HAVE_ATTRIBUTE(always_inline)
#define DVL_ALWAYS_INLINE inline __attribute__((always_inline))
#elif defined(_MSC_VER)
#define DVL_ALWAYS_INLINE __forceinline
#else
#define DVL_ALWAYS_INLINE inline
#endif
🔥 Mark `dun_render` functions as `hot`
5 years ago
Minor rendering cleanups Extracted from various open PRs, for ease of reviewing.
2 years ago
#if DVL_HAVE_ATTRIBUTE(noinline)
#define DVL_NO_INLINE __attribute__((noinline))
#elif defined(_MSC_VER)
#define DVL_NO_INLINE __declspec(noinline)
#else
#define DVL_NO_INLINE
#endif
🔥 Mark `dun_render` functions as `hot`
5 years ago
#if DVL_HAVE_ATTRIBUTE(hot)
#define DVL_ATTRIBUTE_HOT __attribute__((hot))
#else
#define DVL_ATTRIBUTE_HOT
#endif
Overhaul tests 1. Adds a `libdevilution_so` target when tests are enabled. 2. Each test file is now a separate binary target linked against `libdevilutionx_so` (can now run tests in parallel). 3. Tests are now defined in a separate `test/CMakeLists.txt` file. 4. Building the tests is now controlled by the standard `BUILD_TESTING` option (defined by CTest). 5. Tests are now built by default. 6. On CI, test errors are now reported. Also: * `.clang-format`: Enable SortIncludes in tests * `path_test.cpp`: Fix -Wsign-compare
4 years ago
// Any global data used by tests must be marked with `DVL_API_FOR_TEST`.
#if defined(_MSC_VER) && defined(BUILD_TESTING)
#ifdef _DVL_EXPORTING
#define DVL_API_FOR_TEST __declspec(dllexport)
#else
#define DVL_API_FOR_TEST __declspec(dllimport)
#endif
#else
#define DVL_API_FOR_TEST
#endif
Add hint to avoid bugprone-use-after-move warnings Makes clang (and GCC) consider item.Clear() a reinitialisation of a moved variable - see https://clang.llvm.org/extra/clang-tidy/checks/bugprone-use-after-move.html#reinitialization
4 years ago
#if defined(__clang__)
#define DVL_REINITIALIZES [[clang::reinitializes]]
#elif DVL_HAVE_ATTRIBUTE(reinitializes)
#define DVL_REINITIALIZES __attribute__((reinitializes))
#else
#define DVL_REINITIALIZES
#endif
Fix build with NONET and no exceptions Fixes the build with `-fno-rtti` and `-fno-exceptions`. Building with these flags reduces the binary size by more than 200 KiB.
4 years ago
Fix DVL_EXCEPTIONS on clang
4 years ago
#if ((defined(__GNUC__) || defined(__clang__)) && !defined(__EXCEPTIONS)) || defined(_MSC_VER) && !_HAS_EXCEPTIONS
Simplify palette handling Gets rid of `orig_palette`, we now always have only 2 palettes: 1. `logical_palette` This palette has color cycling / swapping applied but no global effects such as brightness / fade-in. 2. `system_palette` This palette is the actual palette used for rendering. It is usually `logical_palette` with the global brightness setting and fade-in/out applied. Additionally, we now keep the k-d tree around and use it to update single colors. The colors that are color-cycled / swapped are never included in the k-d tree, so the tree does not need updating on color cycles/swaps.
9 months ago
// NOLINTNEXTLINE(modernize-macro-to-enum)
Fix build with NONET and no exceptions Fixes the build with `-fno-rtti` and `-fno-exceptions`. Building with these flags reduces the binary size by more than 200 KiB.
4 years ago
#define DVL_EXCEPTIONS 0
#else
Simplify palette handling Gets rid of `orig_palette`, we now always have only 2 palettes: 1. `logical_palette` This palette has color cycling / swapping applied but no global effects such as brightness / fade-in. 2. `system_palette` This palette is the actual palette used for rendering. It is usually `logical_palette` with the global brightness setting and fade-in/out applied. Additionally, we now keep the k-d tree around and use it to update single colors. The colors that are color-cycled / swapped are never included in the k-d tree, so the tree does not need updating on color cycles/swaps.
9 months ago
// NOLINTNEXTLINE(modernize-macro-to-enum)
Fix build with NONET and no exceptions Fixes the build with `-fno-rtti` and `-fno-exceptions`. Building with these flags reduces the binary size by more than 200 KiB.
4 years ago
#define DVL_EXCEPTIONS 1
#endif
dun_render: Overhaul mask handling We notice that masks can be described by 2 parameters: 1. Whether they have 0 or 1 as their high bits. 2. Whether they shift to the left or to the right on the next line. Describing masks this way allows us to lift them to template variables and simplify the code. We also avoid handling the mask in the `RenderLine` loop entirely. Also fixes a foliage rendering bug: Transparent foliage pixels were previously blended but they should have been simply skipped.
3 years ago
#if defined(_MSC_VER)
#define DVL_RESTRICT __restrict
#else
#define DVL_RESTRICT __restrict__
#endif
blit_impl: Add length assumptions We know that length is never 0. Letting the compiler know that allows it to optimize one instruction away. Moreover, for Fill runs, we also know that the length is at least 2.
2 years ago
#ifdef __has_cpp_attribute
#if __has_cpp_attribute(assume) >= 202207L
#define DVL_ASSUME(...) [[assume(__VA_ARGS__)]]
#endif
#endif
#ifndef DVL_ASSUME
#if defined(__clang__)
#define DVL_ASSUME(...) \
do { \
__builtin_assume(__VA_ARGS__); \
} while (false)
#elif defined(_MSC_VER)
#define DVL_ASSUME(...) \
do { \
__assume(__VA_ARGS__); \
} while (false)
#elif defined(__GNUC__)
#if __GNUC__ >= 13
#define DVL_ASSUME(...) __attribute__((__assume__(__VA_ARGS__)))
#endif
#endif
#endif
#ifndef DVL_ASSUME
#define DVL_ASSUME(...)
#endif
Fix some compilation warnings
2 years ago
#if defined(__clang__) || defined(__GNUC__)
#define DVL_UNREACHABLE() __builtin_unreachable()
#elif defined(_MSC_VER)
#define DVL_UNREACHABLE() __assume(false)
#else
#define DVL_UNREACHABLE()
#endif
Async load: Handle errors
1 year ago
#if DVL_HAVE_BUILTIN(__builtin_expect)
#define DVL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
#define DVL_PREDICT_TRUE(x) (__builtin_expect(false || (x), true))
#else
#define DVL_PREDICT_FALSE(x) (x)
#define DVL_PREDICT_TRUE(x) (x)
#endif