Fix buffer overflow in windows tap driver

6 years ago · b3331c5ec2
1 changed files with 2 additions and 1 deletions
--- a/windows/TapDriver6/adapter.c
+++ b/windows/TapDriver6/adapter.c
@ -272,7 +272,8 @@ tapReadConfiguration(

        if (status == NDIS_STATUS_SUCCESS)
        {
-            if (configParameter->ParameterType == NdisParameterString)
+            if (configParameter->ParameterType == NdisParameterString
+                && configParameter->ParameterData.StringData.Length <= sizeof(Adapter->NetCfgInstanceIdBuffer) - sizeof(WCHAR))
            {
                DEBUGP (("[TAP] NdisReadConfiguration (NetCfgInstanceId=%wZ)\n",
                    &configParameter->ParameterData.StringData ));